Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2347063003: Add 'Get Info' to contextual menu to display QuickView. (Closed)

Created:
4 years, 3 months ago by harukam
Modified:
4 years, 3 months ago
Reviewers:
fukino
CC:
chromium-reviews, extensions-reviews_chromium.org, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add 'Get Info' to contextual menu to display QuickView. BUG=474318 TEST=manuallry tested Committed: https://crrev.com/3e538da7ac2cae29a1ffdb7d152d24fe72684b71 Cr-Commit-Position: refs/heads/master@{#419157}

Patch Set 1 : Add 'Get Info' to contextual menu to display QuickView. #

Total comments: 4

Patch Set 2 : Add 'Get Info' to contextual menu to display QuickView. #

Patch Set 3 : Add 'Get Info' to contextual menu to display QuickView. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager_commands.js View 1 1 chunk +30 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/quick_view_controller.js View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/main.html View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
harukam
PTAL
4 years, 3 months ago (2016-09-16 08:33:13 UTC) #2
fukino
https://codereview.chromium.org/2347063003/diff/1/chrome/app/chromeos_strings.grdp File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/2347063003/diff/1/chrome/app/chromeos_strings.grdp#newcode439 chrome/app/chromeos_strings.grdp:439: <message name="IDS_FILE_BROWSER_GET_INFO_BUTTON_LABEL" desc="Button Label."> Please be more descriptive on ...
4 years, 3 months ago (2016-09-16 11:17:30 UTC) #3
harukam
Thanks! Please take another look. https://codereview.chromium.org/2347063003/diff/1/chrome/app/chromeos_strings.grdp File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/2347063003/diff/1/chrome/app/chromeos_strings.grdp#newcode439 chrome/app/chromeos_strings.grdp:439: <message name="IDS_FILE_BROWSER_GET_INFO_BUTTON_LABEL" desc="Button Label."> ...
4 years, 3 months ago (2016-09-16 12:39:58 UTC) #4
fukino
lgtm
4 years, 3 months ago (2016-09-16 12:40:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347063003/40001
4 years, 3 months ago (2016-09-16 12:41:02 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-16 13:38:19 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 13:40:02 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/3e538da7ac2cae29a1ffdb7d152d24fe72684b71
Cr-Commit-Position: refs/heads/master@{#419157}

Powered by Google App Engine
This is Rietveld 408576698