[gin] Support ConvertableToTraceFormat arguments for events coming from V8.

Support ConvertableToTraceFormat arguments for events coming from V8.

BUG=406277
Committed: https://crrev.com/7722c1c238cdef0616cf4654a056863ef0b9e4ac
Cr-Commit-Position: refs/heads/master@{#420539}

[alph, 2016-09-15 23:44:01]

alph@chromium.org changed reviewers:
+ fmeawad@chromium.org, jochen@chromium.org

[alph, 2016-09-15 23:44:02]

PTAL

[alph, 2016-09-15 23:44:09]

The CQ bit was checked by alph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 23:44:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fmeawad, 2016-09-15 23:53:44]

lgtm with a comment.

https://codereview.chromium.org/2347033002/diff/1/gin/v8_platform.cc
File gin/v8_platform.cc (right):

https://codereview.chromium.org/2347033002/diff/1/gin/v8_platform.cc#newcode100
gin/v8_platform.cc:100:
std::unique_ptr<base::trace_event::ConvertableToTraceFormat> convertables[2];
Instead of the 2 if conditions, maybe a tiny for loop that we hope the compiler
will unroll?

[alph, 2016-09-15 23:58:14]

https://codereview.chromium.org/2347033002/diff/1/gin/v8_platform.cc
File gin/v8_platform.cc (right):

https://codereview.chromium.org/2347033002/diff/1/gin/v8_platform.cc#newcode100
gin/v8_platform.cc:100:
std::unique_ptr<base::trace_event::ConvertableToTraceFormat> convertables[2];
On 2016/09/15 23:53:44, fmeawad wrote:
> Instead of the 2 if conditions, maybe a tiny for loop that we hope the
compiler
> will unroll?

I doubt it will be able to unroll it as the num_args in not a compile time
constant.

[commit-bot: I haz the power, 2016-09-16 00:41:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 00:41:41]

Dry run: This issue passed the CQ dry run.

[alph, 2016-09-16 06:29:32]

Description was changed from

==========
Support ConvertableToTraceFormat arguments for events coming from V8.

BUG=406277
==========

to

==========
Support ConvertableToTraceFormat arguments for events coming from V8.

BUG=406277
==========

[jochen (gone - plz use gerrit), 2016-09-19 14:24:29]

lgtm

[alph, 2016-09-23 00:47:04]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2016-09-23 00:47:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 01:47:39]

Description was changed from

==========
Support ConvertableToTraceFormat arguments for events coming from V8.

BUG=406277
==========

to

==========
Support ConvertableToTraceFormat arguments for events coming from V8.

BUG=406277
==========

[commit-bot: I haz the power, 2016-09-23 01:47:40]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-23 01:51:04]

Description was changed from

==========
Support ConvertableToTraceFormat arguments for events coming from V8.

BUG=406277
==========

to

==========
Support ConvertableToTraceFormat arguments for events coming from V8.

BUG=406277

Committed: https://crrev.com/7722c1c238cdef0616cf4654a056863ef0b9e4ac
Cr-Commit-Position: refs/heads/master@{#420539}
==========

[commit-bot: I haz the power, 2016-09-23 01:51:05]

Patchset 1 (id:??) landed as
https://crrev.com/7722c1c238cdef0616cf4654a056863ef0b9e4ac
Cr-Commit-Position: refs/heads/master@{#420539}