Issue 234703006: Prevent real stack overflow when handling JavaScript stack overflow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 234703006: Prevent real stack overflow when handling JavaScript stack overflow (Closed)

Created:
6 years, 8 months ago by Jarin

Modified:
6 years, 8 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Prevent real stack overflow when handling JavaScript stack overflow In stack overflow handling, we invoke Error.stackTraceLimit to limit the size of produced stack trace. However, if there is a getter installed on the stackTraceLimit property, we may overflow again and end up in an infinite loop. This change disallows getters and setters on Error.stackTraceLimit. BUG=

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
	M	src/messages.js	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	test/mjsunit/stack-traces-overflow.js	View		2 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages