Fix how JsChecker::GetBoolImpl enforces boolean result

Fix how JsChecker::GetBoolImpl enforces boolean result

The "!!" trick is applied to domAutomationController.send instead
of the expression. This could cause DomAutomationController to drop
result of a non-boolean expression. As a result, ExpectTrue etc times
out.

BUG=
TEST=JsChecker::ExpectTrue with non-boolean expression should not time out.

Committed: https://crrev.com/133105cf6d16f3c0bae67cbf2003db44b8293a47
Cr-Commit-Position: refs/heads/master@{#419296}

[xiyuan, 2016-09-15 23:05:58]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 23:06:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 00:18:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 00:18:31]

Dry run: This issue passed the CQ dry run.

[xiyuan, 2016-09-16 07:41:47]

Description was changed from

==========
Fix how JsChecker::GetBoolImpl enforces boolean result

The "!!" trick is applied to domAutomationController.send instead
of the expression. This could cause DomAutomationController to drop
result of a non-boolean expression. As a result, ExpectTrue and
friends times out.

BUG=
TEST=JsChecker::ExpectTrue with non-boolean expression should not time out.
==========

to

==========
Fix how JsChecker::GetBoolImpl enforces boolean result

The "!!" trick is applied to domAutomationController.send instead
of the expression. This could cause DomAutomationController to drop
result of a non-boolean expression. As a result, ExpectTrue etc times out.

BUG=
TEST=JsChecker::ExpectTrue with non-boolean expression should not time out.
==========

[xiyuan, 2016-09-16 07:42:31]

Description was changed from

==========
Fix how JsChecker::GetBoolImpl enforces boolean result

The "!!" trick is applied to domAutomationController.send instead
of the expression. This could cause DomAutomationController to drop
result of a non-boolean expression. As a result, ExpectTrue etc times out.

BUG=
TEST=JsChecker::ExpectTrue with non-boolean expression should not time out.
==========

to

==========
Fix how JsChecker::GetBoolImpl enforces boolean result

The "!!" trick is applied to domAutomationController.send instead
of the expression. This could cause DomAutomationController to drop
result of a non-boolean expression. As a result, ExpectTrue etc times
out.

BUG=
TEST=JsChecker::ExpectTrue with non-boolean expression should not time out.
==========

[xiyuan, 2016-09-16 07:43:31]

xiyuan@chromium.org changed reviewers:
+ alemate@chromium.org

[achuithb, 2016-09-16 22:07:31]

achuith@chromium.org changed reviewers:
+ achuith@chromium.org

[achuithb, 2016-09-16 22:07:31]

lgtm

[xiyuan, 2016-09-16 22:08:43]

On 2016/09/16 22:07:31, achuith(OOO_until_9_28) wrote:
> lgtm

Thanks for reviewing during OOO. :)

[xiyuan, 2016-09-16 22:09:05]

The CQ bit was checked by xiyuan@chromium.org

[commit-bot: I haz the power, 2016-09-16 22:09:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xiyuan, 2016-09-16 22:09:51]

+kumarniranjan fyi

[commit-bot: I haz the power, 2016-09-16 22:15:38]

Description was changed from

==========
Fix how JsChecker::GetBoolImpl enforces boolean result

The "!!" trick is applied to domAutomationController.send instead
of the expression. This could cause DomAutomationController to drop
result of a non-boolean expression. As a result, ExpectTrue etc times
out.

BUG=
TEST=JsChecker::ExpectTrue with non-boolean expression should not time out.
==========

to

==========
Fix how JsChecker::GetBoolImpl enforces boolean result

The "!!" trick is applied to domAutomationController.send instead
of the expression. This could cause DomAutomationController to drop
result of a non-boolean expression. As a result, ExpectTrue etc times
out.

BUG=
TEST=JsChecker::ExpectTrue with non-boolean expression should not time out.
==========

[commit-bot: I haz the power, 2016-09-16 22:15:39]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-16 22:17:23]

Description was changed from

==========
Fix how JsChecker::GetBoolImpl enforces boolean result

The "!!" trick is applied to domAutomationController.send instead
of the expression. This could cause DomAutomationController to drop
result of a non-boolean expression. As a result, ExpectTrue etc times
out.

BUG=
TEST=JsChecker::ExpectTrue with non-boolean expression should not time out.
==========

to

==========
Fix how JsChecker::GetBoolImpl enforces boolean result

The "!!" trick is applied to domAutomationController.send instead
of the expression. This could cause DomAutomationController to drop
result of a non-boolean expression. As a result, ExpectTrue etc times
out.

BUG=
TEST=JsChecker::ExpectTrue with non-boolean expression should not time out.

Committed: https://crrev.com/133105cf6d16f3c0bae67cbf2003db44b8293a47
Cr-Commit-Position: refs/heads/master@{#419296}
==========

[commit-bot: I haz the power, 2016-09-16 22:17:25]

Patchset 1 (id:??) landed as
https://crrev.com/133105cf6d16f3c0bae67cbf2003db44b8293a47
Cr-Commit-Position: refs/heads/master@{#419296}