Issue 23470005: move decision to smash invmatrix into unit-space (for faster repeat/mirror to after the call to pos…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23470005: move decision to smash invmatrix into unit-space (for faster repeat/mirror to after the call to pos… (Closed)

Created:
7 years, 3 months ago by reed1

Modified:
7 years, 3 months ago

Reviewers:
humper

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

move decision to smash invmatrix into unit-space (for faster repeat/mirror to after the call to possiblyScaleImage(), so we don't confuse that code with a munged matrix. Fixes the scaled_tilemodes gm for HQ BUG= R=humper@google.com Committed: https://code.google.com/p/skia/source/detail?r=11152

Patch Set 1 #

Patch Set 2 : rebase #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
	M	src/core/SkBitmapProcState.cpp	View		2 chunks	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

reed1

will require rebaselining the two GMs around scaled_tilemodes

7 years, 3 months ago (2013-09-06 15:43:49 UTC) #1

humper

On 2013/09/06 15:43:49, reed1 wrote: > will require rebaselining the two GMs around scaled_tilemodes LGTM; ...

7 years, 3 months ago (2013-09-09 13:39:21 UTC) #2

commit-bot: I haz the power

No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...

7 years, 3 months ago (2013-09-09 13:39:29 UTC) #3

reed1

7 years, 3 months ago (2013-09-09 13:43:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r11152 (presubmit successful).

Expand Messages | Collapse Messages