Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 23470002: Build unix_dir for NaCl. (Closed)

Created:
7 years, 3 months ago by Sam Clegg
Modified:
7 years, 3 months ago
Reviewers:
Roland McGrath
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/nacl-newlib.git@master
Visibility:
Public.

Description

Build unix_dir for NaCl. There are several functions in the 'unix' subfolder which we currently ship headers for, but not implementions. e.g dirname(3) and basename(3). This change adds the 'unix' directory to the NaCl build of newlib and excludes the 4 functions which don't currently compile. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3651 TEST= pnacl/build.sh R=mcgrathr@chromium.org Committed: https://git.chromium.org/gitweb?p=native_client/nacl-newlib.git;a=commit;h=c37e9ae

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M newlib/configure.host View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Sam Clegg
7 years, 3 months ago (2013-08-26 21:14:04 UTC) #1
Roland McGrath
needs trybot results for x86 and ARM toolchains too
7 years, 3 months ago (2013-08-26 21:33:41 UTC) #2
Sam Clegg
On 2013/08/26 21:33:41, Roland McGrath wrote: > needs trybot results for x86 and ARM toolchains ...
7 years, 3 months ago (2013-08-27 17:44:33 UTC) #3
Roland McGrath
On 2013/08/27 17:44:33, Sam Clegg wrote: > On 2013/08/26 21:33:41, Roland McGrath wrote: > > ...
7 years, 3 months ago (2013-08-27 17:48:37 UTC) #4
Sam Clegg
7 years, 3 months ago (2013-08-27 21:26:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as rc37e9ae (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698