Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2346973004:
Mark WEBGL_compressed_texture_s3tc_srgb as draft (Closed)
|
Created:
4 years, 3 months ago by Kai Ninomiya Modified:
4 years, 3 months ago Reviewers:
Ken Russell (switch to Gerrit) CC:
chromium-reviews, blink-reviews, haraken, ccameron Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMark WEBGL_compressed_texture_s3tc_srgb as draft
Plus add TODO for https://bugs.chromium.org/p/chromium/issues/detail?id=647892
BUG=630498
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
Committed: https://crrev.com/f960e8b709a40c733e6b203b9bac5d58a093b2d1
Cr-Commit-Position: refs/heads/master@{#419583}
Patch Set 1 #
Messages
Total messages: 18 (9 generated)
Description was changed from ========== Mark WEBGL_compressed_texture_s3tc_srgb as draft BUG=630498 ========== to ========== Mark WEBGL_compressed_texture_s3tc_srgb as draft BUG=630498 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel ==========
Description was changed from ========== Mark WEBGL_compressed_texture_s3tc_srgb as draft BUG=630498 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel ========== to ========== Mark WEBGL_compressed_texture_s3tc_srgb as draft Plus add TODO for https://bugs.chromium.org/p/chromium/issues/detail?id=647892 BUG=630498 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel ==========
Description was changed from ========== Mark WEBGL_compressed_texture_s3tc_srgb as draft BUG=630498 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel ========== to ========== Mark WEBGL_compressed_texture_s3tc_srgb as draft Plus add TODO for https://bugs.chromium.org/p/chromium/issues/detail?id=647892 BUG=630498 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel ==========
kainino@chromium.org changed reviewers: + kbr@chromium.org
kainino@chromium.org changed reviewers: + kbr@chromium.org
PTAL
The CQ bit was checked by kbr@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Mark WEBGL_compressed_texture_s3tc_srgb as draft Plus add TODO for https://bugs.chromium.org/p/chromium/issues/detail?id=647892 BUG=630498 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel ========== to ========== Mark WEBGL_compressed_texture_s3tc_srgb as draft Plus add TODO for https://bugs.chromium.org/p/chromium/issues/detail?id=647892 BUG=630498 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Mark WEBGL_compressed_texture_s3tc_srgb as draft Plus add TODO for https://bugs.chromium.org/p/chromium/issues/detail?id=647892 BUG=630498 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel ========== to ========== Mark WEBGL_compressed_texture_s3tc_srgb as draft Plus add TODO for https://bugs.chromium.org/p/chromium/issues/detail?id=647892 BUG=630498 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/f960e8b709a40c733e6b203b9bac5d58a093b2d1 Cr-Commit-Position: refs/heads/master@{#419583} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/f960e8b709a40c733e6b203b9bac5d58a093b2d1 Cr-Commit-Position: refs/heads/master@{#419583}
Message was sent while issue was closed.
On 2016/09/19 21:57:56, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as > https://crrev.com/f960e8b709a40c733e6b203b9bac5d58a093b2d1 > Cr-Commit-Position: refs/heads/master@{#419583} This is causing failures on WebglConformance_conformance2_rendering_blitframebuffer_filter_srgb on the GPU FYI bots: https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28A... https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28N... https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28A... Are there expectations that should be changed?
Message was sent while issue was closed.
Description was changed from ========== Mark WEBGL_compressed_texture_s3tc_srgb as draft Plus add TODO for https://bugs.chromium.org/p/chromium/issues/detail?id=647892 BUG=630498 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/f960e8b709a40c733e6b203b9bac5d58a093b2d1 Cr-Commit-Position: refs/heads/master@{#419583} ========== to ========== Mark WEBGL_compressed_texture_s3tc_srgb as draft Plus add TODO for https://bugs.chromium.org/p/chromium/issues/detail?id=647892 BUG=630498 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/f960e8b709a40c733e6b203b9bac5d58a093b2d1 Cr-Commit-Position: refs/heads/master@{#419583} ==========
Message was sent while issue was closed.
On 2016/09/20 18:32:12, ccameron wrote: > On 2016/09/19 21:57:56, commit-bot: I haz the power wrote: > > Patchset 1 (id:??) landed as > > https://crrev.com/f960e8b709a40c733e6b203b9bac5d58a093b2d1 > > Cr-Commit-Position: refs/heads/master@{#419583} > > This is causing failures on > WebglConformance_conformance2_rendering_blitframebuffer_filter_srgb on the GPU > FYI bots: > > https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28A... > https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28N... > https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28A... > > Are there expectations that should be changed? It wasn't this CL; it was probably https://codereview.chromium.org/2354693002 . We'll update the expectations.
Message was sent while issue was closed.
On 2016/09/20 at 20:28:19, kbr wrote: > On 2016/09/20 18:32:12, ccameron wrote: > > On 2016/09/19 21:57:56, commit-bot: I haz the power wrote: > > > Patchset 1 (id:??) landed as > > > https://crrev.com/f960e8b709a40c733e6b203b9bac5d58a093b2d1 > > > Cr-Commit-Position: refs/heads/master@{#419583} > > > > This is causing failures on > > WebglConformance_conformance2_rendering_blitframebuffer_filter_srgb on the GPU > > FYI bots: > > > > https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28A... > > https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28N... > > https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28A... > > > > Are there expectations that should be changed? > > It wasn't this CL; it was probably https://codereview.chromium.org/2354693002 . We'll update the expectations. Apologies, I forgot to notify here that I did a CL to fix this: https://codereview.chromium.org/2356773002
Message was sent while issue was closed.
On 2016/09/20 20:30:20, Corentin Wallez wrote: > On 2016/09/20 at 20:28:19, kbr wrote: > > On 2016/09/20 18:32:12, ccameron wrote: > > > On 2016/09/19 21:57:56, commit-bot: I haz the power wrote: > > > > Patchset 1 (id:??) landed as > > > > https://crrev.com/f960e8b709a40c733e6b203b9bac5d58a093b2d1 > > > > Cr-Commit-Position: refs/heads/master@{#419583} > > > > > > This is causing failures on > > > WebglConformance_conformance2_rendering_blitframebuffer_filter_srgb on the > GPU > > > FYI bots: > > > > > > > https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28A... > > > > https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28N... > > > > https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28A... > > > > > > Are there expectations that should be changed? > > > > It wasn't this CL; it was probably https://codereview.chromium.org/2354693002 > . We'll update the expectations. > > Apologies, I forgot to notify here that I did a CL to fix this: > https://codereview.chromium.org/2356773002 No worries; thanks Corentin for taking care of this. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
