Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Unified Diff: content/browser/media/media_browsertest.cc

Issue 2346963004: Enable media browsertests on Android (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/media_browsertest.cc
diff --git a/content/browser/media/media_browsertest.cc b/content/browser/media/media_browsertest.cc
index 826a072ca8bc3b3cd04b83664486b88c1a6a2e56..f7237c6078a0fe87a433167f2265fbaf02b795db 100644
--- a/content/browser/media/media_browsertest.cc
+++ b/content/browser/media/media_browsertest.cc
@@ -101,6 +101,8 @@ class MediaTest : public testing::WithParamInterface<bool>,
}
};
+// Android doesn't support Theora.
+#if !defined(OS_ANDROID)
IN_PROC_BROWSER_TEST_P(MediaTest, VideoBearTheora) {
PlayVideo("bear.ogv", GetParam());
}
@@ -108,6 +110,7 @@ IN_PROC_BROWSER_TEST_P(MediaTest, VideoBearTheora) {
IN_PROC_BROWSER_TEST_P(MediaTest, VideoBearSilentTheora) {
PlayVideo("bear_silent.ogv", GetParam());
}
+#endif // !defined(OS_ANDROID)
IN_PROC_BROWSER_TEST_P(MediaTest, VideoBearWebm) {
PlayVideo("bear.webm", GetParam());
@@ -136,9 +139,12 @@ IN_PROC_BROWSER_TEST_P(MediaTest, MAYBE_VideoBearMp4) {
PlayVideo("bear.mp4", GetParam());
}
+// Android devices usually only support baseline, main and high.
+#if !defined(OS_ANDROID)
IN_PROC_BROWSER_TEST_P(MediaTest, VideoBearHighBitDepthMp4) {
PlayVideo("bear-320x180-hi10p.mp4", GetParam());
}
+#endif // !defined(OS_ANDROID)
// Crashes on Mac only. http://crbug.com/621857
#if defined(OS_MACOSX)
@@ -237,7 +243,7 @@ IN_PROC_BROWSER_TEST_P(MediaTest, VideoTulipWebm) {
// Covers tear-down when navigating away as opposed to browser exiting.
IN_PROC_BROWSER_TEST_F(MediaTest, Navigate) {
- PlayVideo("bear.ogv", false);
+ PlayVideo("bear.webm", false);
NavigateToURL(shell(), GURL(url::kAboutBlankURL));
EXPECT_FALSE(shell()->web_contents()->IsCrashed());
}
« no previous file with comments | « build/android/pylib/gtest/filter/content_browsertests_disabled ('k') | content/browser/media/media_color_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698