Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(971)

Unified Diff: scripts/slave/unittests/results_dashboard_test.py

Issue 2346963003: Updating perf recipe for disabled chartjson data. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/unittests/results_dashboard_test.py
diff --git a/scripts/slave/unittests/results_dashboard_test.py b/scripts/slave/unittests/results_dashboard_test.py
index 4cd86a48caa6584bd13e7ea6ec3b4f9dfd722be7..682a2341f95f81cd84dbdc1d0c4a1b4373b6ebe7 100755
--- a/scripts/slave/unittests/results_dashboard_test.py
+++ b/scripts/slave/unittests/results_dashboard_test.py
@@ -51,7 +51,7 @@ class ResultsDashboardFormatTest(unittest.TestCase):
self.mox.ReplayAll()
v1json = results_dashboard.MakeDashboardJsonV1(
- {'some_json': 'from_telemetry'},
+ {'some_json': 'from_telemetry', 'disabled': False},
{
'rev': 'f46bf3c',
'git_revision': 'f46bf3c',
@@ -64,11 +64,11 @@ class ResultsDashboardFormatTest(unittest.TestCase):
'10',
{'a_annotation': 'xyz', 'r_my_rev': '789abc01'},
True)
- self.assertEqual(
+ self.assertEqual((False,
{
'master': 'ChromiumPerf',
'bot': 'my-bot',
- 'chart_data': {'some_json': 'from_telemetry'},
+ 'chart_data': {'some_json': 'from_telemetry', 'disabled': False},
'is_ref': True,
'test_suite_name': 'foo_test',
'point_id': 307226,
@@ -83,7 +83,21 @@ class ResultsDashboardFormatTest(unittest.TestCase):
'chromium': 'f46bf3c',
'my_rev': '789abc01'
}
- },
+ }),
+ v1json)
+
+ def test_MakeDashboardJsonV1WithDisabledBenchmark(self):
+ v1json = results_dashboard.MakeDashboardJsonV1(
+ {'some_json': 'from_telemetry', 'disabled': True},
+ {},
+ 'foo_test',
+ 'my-bot',
+ 'Builder',
+ '10',
+ {'a_annotation': 'xyz', 'r_my_rev': '789abc01'},
+ True)
+ self.assertEqual(
+ (True, {'some_json': 'from_telemetry', 'disabled': True}),
v1json)
def test_MakeListOfPoints_MinimalCase(self):

Powered by Google App Engine
This is Rietveld 408576698