Updating perf recipe for disabled chartjson data.

scripts/slave/results_dashboard.py

Index: scripts/slave/results_dashboard.py
diff --git a/scripts/slave/results_dashboard.py b/scripts/slave/results_dashboard.py
index c42a8c1ce4e02dbb58c5c00028a66e063117109a..9bb39e4a1daaa46eeda910173d056607b1d616bf 100755
--- a/scripts/slave/results_dashboard.py
+++ b/scripts/slave/results_dashboard.py
@@ -240,6 +240,11 @@ def MakeDashboardJsonV1(chart_json, revision_dict, test_name, bot, buildername,
     print 'Error: No json output from telemetry.'
     print '@@@STEP_FAILURE@@@'
 
+  # If benchmark was disabled it is a success, so just return the
+  # given chart_json since no results will be written to dashboard
+  if chart_json['disabled']:

[perezju, 2016/09/22 08:50:27]

change this to chart_json.get('disabled', False), in case we get an old
chartjson (e.g. on release bots we sometimes run new recipe code with old
chromium/catapult repositories).

[eyaich1, 2016/09/26 15:22:11]

Done.

+    return (True, chart_json)

[perezju, 2016/09/22 08:50:27]

I don't like this change. I think we still want the wrapping data with master,
versions, etc. (i.e. the "fields" dict below) to be shown on the waterfall, even
if the benchmark was disabled at the time.

I would suggest either:

1) copy the enabled/disabled value from the inner "chart_data" into the outer
"fields"; then test for results['enabled'] in _SendResultsToDashboard before
actually sending the data; or

2) don't change this function at all, and in _SendResultsToDashboard test for
results['chart_data'].get('enabled', False) before sending the data.

[eyaich1, 2016/09/26 15:22:11]

I went with #2.  My original thinking was that I reuse this method in my new
swarming recipe in https://codereview.chromium.org/2330133002/ so I was trying
to do the disabled check only once, but this makes more sense.  Hopefully the
code in runtests.py will be going away soon once the perf dashboard is swarmed
:)

Done. 

+
   # The master name used for the dashboard is the CamelCase name returned by
   # GetActiveMaster(), and not the canonical master name with dots.
   master = slave_utils.GetActiveMaster()
@@ -271,7 +276,7 @@ def MakeDashboardJsonV1(chart_json, revision_dict, test_name, bot, buildername,
       'chart_data': chart_json,
       'is_ref': is_ref,
   }
-  return fields
+  return (False, fields)
 
 
 def _GetStdioUriColumn(test_name, buildername, buildnumber):