Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 23469002: [webpagereplay] Add command exit. (Closed)

Created:
7 years, 3 months ago by chrisgao (Use stgao instead)
Modified:
7 years, 3 months ago
Reviewers:
tonyg
CC:
web-page-replay-dev_googlegroups.com
Visibility:
Public.

Description

[webpagereplay] Add command exit. This is to make web page replay exits normally with graceful cleanup like restoring dns.

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M customhandlers.py View 1 chunk +3 lines, -0 lines 0 comments Download
M servermanager.py View 2 chunks +3 lines, -0 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
chrisgao (Use stgao instead)
https://codereview.chromium.org/23469002/diff/3001/servermanager.py File servermanager.py (right): https://codereview.chromium.org/23469002/diff/3001/servermanager.py#newcode103 servermanager.py:103: if self.should_exit: I think we don't need a lock ...
7 years, 3 months ago (2013-08-27 16:34:18 UTC) #1
chrisgao (Use stgao instead)
ptal
7 years, 3 months ago (2013-08-27 16:34:50 UTC) #2
tonyg
lgtm https://codereview.chromium.org/23469002/diff/3001/servermanager.py File servermanager.py (right): https://codereview.chromium.org/23469002/diff/3001/servermanager.py#newcode103 servermanager.py:103: if self.should_exit: On 2013/08/27 16:34:18, chrisgao wrote: > ...
7 years, 3 months ago (2013-08-28 01:35:57 UTC) #3
tonyg
7 years, 3 months ago (2013-08-28 01:40:00 UTC) #4
On 2013/08/28 01:35:57, tonyg wrote:
> lgtm
> 
> https://codereview.chromium.org/23469002/diff/3001/servermanager.py
> File servermanager.py (right):
> 
> https://codereview.chromium.org/23469002/diff/3001/servermanager.py#newcode103
> servermanager.py:103: if self.should_exit:
> On 2013/08/27 16:34:18, chrisgao wrote:
> > I think we don't need a lock for |should_exit|. It can only be set to True.
> And
> > if we miss the updated value, we should not miss it in the next round.
> 
> Agreed. Python's GIL takes care of this.

Committed revision 520.

You'll need to roll chromium's src/DEPS file to include this revision in order
to use this in Telemetry.

Powered by Google App Engine
This is Rietveld 408576698