Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Unified Diff: ui/views/controls/combobox/combobox.cc

Issue 2346893002: Share a common alpha value used for displaying disabled state in Harmony (Closed)
Patch Set: compiling is underrated Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/controls/button/toggle_button.cc ('k') | ui/views/controls/focusable_border.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/combobox/combobox.cc
diff --git a/ui/views/controls/combobox/combobox.cc b/ui/views/controls/combobox/combobox.cc
index bb8623a26f631e183c6b62289581e95a1336fc19..e72f4b8c37fbfd0a86681409c8310495474365f4 100644
--- a/ui/views/controls/combobox/combobox.cc
+++ b/ui/views/controls/combobox/combobox.cc
@@ -833,10 +833,8 @@ void Combobox::PaintText(gfx::Canvas* canvas) {
SkPaint paint;
SkColor arrow_color = GetNativeTheme()->GetSystemColor(
ui::NativeTheme::kColorId_ButtonEnabledColor);
- // TODO(estade): share this disabled alpha value with other places that use
- // it.
if (!enabled())
- arrow_color = SkColorSetA(arrow_color, 0x61);
+ arrow_color = SkColorSetA(arrow_color, gfx::kDisabledControlAlpha);
paint.setColor(arrow_color);
paint.setAntiAlias(true);
canvas->DrawPath(path, paint);
« no previous file with comments | « ui/views/controls/button/toggle_button.cc ('k') | ui/views/controls/focusable_border.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698