third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.h - Issue 2346883003: Only paint the background onto the scrolling contents layer if we have a scrolling contents layer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.h

Issue 2346883003: Only paint the background onto the scrolling contents layer if we have a scrolling contents layer. (Closed)

Patch Set: CompositedLayerMappingTest.BackgroundPaintedIntoGraphicsLayerIfNotCompositedScrolling Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp ('K') | « third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.h

diff --git a/third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.h b/third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.h

index f59205536a1984d9bd579b4d8fa112784bf59708..a77e751587af45c710e7ddcec895c065381189ce 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.h

+++ b/third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.h

@@ -17,10 +17,10 @@ public:

: RenderingTest(SingleChildFrameLoaderClient::create())

{ }

- bool shouldPaintBackgroundOntoScrollingContentsLayer(const char* elementId)

+ bool canPaintBackgroundOntoScrollingContentsLayer(const char* elementId)

{

PaintLayer* paintLayer = toLayoutBlock(getLayoutObjectByElementId(elementId))->layer();

- return paintLayer->shouldPaintBackgroundOntoScrollingContentsLayer();

+ return paintLayer->canPaintBackgroundOntoScrollingContentsLayer();

}

private: