third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp - Issue 2346883003: Only paint the background onto the scrolling contents layer if we have a scrolling contents layer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 2346883003: Only paint the background onto the scrolling contents layer if we have a scrolling contents layer. (Closed)

Patch Set: CompositedLayerMappingTest.BackgroundPaintedIntoGraphicsLayerIfNotCompositedScrolling Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

index f3710f0d20314c96e033feab385d84e7201682cc..eb31b06cd379b40d01c6759f70f2c9803712ccd1 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

@@ -1497,7 +1497,7 @@ static bool layerNeedsCompositedScrolling(PaintLayerScrollableArea::LCDTextMode

// use integer scroll offsets locally when !layer->compositor()->preferCompositingToLCDTextEnabled(),

// we do not check offsets accumulated from the root (including translates). crbug.com/644833

bool backgroundSupportsLCDText = RuntimeEnabledFeatures::compositeOpaqueScrollersEnabled()

- && layer->shouldPaintBackgroundOntoScrollingContentsLayer()

+ && layer->canPaintBackgroundOntoScrollingContentsLayer()

&& layer->backgroundIsKnownToBeOpaqueInRect(toLayoutBox(layer->layoutObject())->paddingBoxRect());

if (mode == PaintLayerScrollableArea::ConsiderLCDText

&& !layer->compositor()->preferCompositingToLCDTextEnabled()