third_party/WebKit/Source/core/paint/PaintLayer.h - Issue 2346883003: Only paint the background onto the scrolling contents layer if we have a scrolling contents layer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayer.h

Issue 2346883003: Only paint the background onto the scrolling contents layer if we have a scrolling contents layer. (Closed)

Patch Set: CompositedLayerMappingTest.BackgroundPaintedIntoGraphicsLayerIfNotCompositedScrolling Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/PaintLayer.h

diff --git a/third_party/WebKit/Source/core/paint/PaintLayer.h b/third_party/WebKit/Source/core/paint/PaintLayer.h

index 0c09203bddc71e3414b1e74104b148d17b437b95..c098405278ccee97e8cae9e231c4f277f3924193 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayer.h

+++ b/third_party/WebKit/Source/core/paint/PaintLayer.h

@@ -438,7 +438,7 @@ public:

// (i.e. the background can scroll with the content). When the background is also

// opaque this allows us to composite the scroller even on low DPI as we can

// draw with subpixel anti-aliasing.

- bool shouldPaintBackgroundOntoScrollingContentsLayer() const;

+ bool canPaintBackgroundOntoScrollingContentsLayer() const;

// NOTE: If you are using hasCompositedLayerMapping to determine the state of compositing for this layer,

// (and not just to do bookkeeping related to the mapping like, say, allocating or deallocating a mapping),

// then you may have incorrect logic. Use compositingState() instead.