third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp - Issue 2346883003: Only paint the background onto the scrolling contents layer if we have a scrolling contents layer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

Issue 2346883003: Only paint the background onto the scrolling contents layer if we have a scrolling contents layer. (Closed)

Patch Set: Merge with master Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp ('k') | third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

index 288c35e5d3954370a2b0fc82fae901f04e0ec6ff..5f691dc12248739528a62f2c18be57b8503aa7f9 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

@@ -299,7 +299,12 @@ void CompositedLayerMapping::updateIsRootForIsolatedGroup()

void CompositedLayerMapping::updateBackgroundPaintsOntoScrollingContentsLayer()

{

- bool shouldPaintOntoScrollingContentsLayer = m_owningLayer.shouldPaintBackgroundOntoScrollingContentsLayer();

+ // We can only paint the background onto the scrolling contents layer if

+ // it would be visually correct and we are using composited scrolling meaning we

+ // have a scrolling contents layer to paint it into.

+ bool shouldPaintOntoScrollingContentsLayer =

+ m_owningLayer.canPaintBackgroundOntoScrollingContentsLayer()

+ && m_owningLayer.getScrollableArea()->usesCompositedScrolling();

if (shouldPaintOntoScrollingContentsLayer != backgroundPaintsOntoScrollingContentsLayer()) {

m_backgroundPaintsOntoScrollingContentsLayer = shouldPaintOntoScrollingContentsLayer;

// If the background is no longer painted onto the scrolling contents