Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 2346883003: Only paint the background onto the scrolling contents layer if we have a scrolling contents layer. (Closed)
Patch Set: Remove obsolete border-radius test. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
7 * Copyright (C) 2010 Google Inc. All rights reserved. 7 * Copyright (C) 2010 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 || (scrollableArea->verticalScrollbar() && scrollableArea->verticalS crollbar()->isCustomScrollbar())) { 130 || (scrollableArea->verticalScrollbar() && scrollableArea->verticalS crollbar()->isCustomScrollbar())) {
131 hasCustomScrollbars = true; 131 hasCustomScrollbars = true;
132 } 132 }
133 } 133 }
134 134
135 // TODO(flackr): When we correctly clip the scrolling contents layer we can 135 // TODO(flackr): When we correctly clip the scrolling contents layer we can
136 // paint locally equivalent backgrounds into it. https://crbug.com/645957 136 // paint locally equivalent backgrounds into it. https://crbug.com/645957
137 if (!style()->hasAutoClip()) 137 if (!style()->hasAutoClip())
138 return false; 138 return false;
139 139
140 // TODO(flackr): We should be able to paint locally attached borders with a border-radius
141 // but these currently do not paint correctly. https://crbug.com/645949
142 if (style()->hasBorderRadius())
143 return false;
144
145 // TODO(flackr): Remove this when box shadows are still painted correctly wh en painting 140 // TODO(flackr): Remove this when box shadows are still painted correctly wh en painting
146 // into the composited scrolling contents layer. https://crbug.com/646464 141 // into the composited scrolling contents layer. https://crbug.com/646464
147 if (style()->boxShadow()) 142 if (style()->boxShadow())
148 return false; 143 return false;
149 144
150 const FillLayer* layer = &(style()->backgroundLayers()); 145 const FillLayer* layer = &(style()->backgroundLayers());
151 for (; layer; layer = layer->next()) { 146 for (; layer; layer = layer->next()) {
152 if (layer->attachment() == LocalBackgroundAttachment) 147 if (layer->attachment() == LocalBackgroundAttachment)
153 continue; 148 continue;
154 149
(...skipping 1033 matching lines...) Expand 10 before | Expand all | Expand 10 after
1188 if (rootElementStyle->hasBackground()) 1183 if (rootElementStyle->hasBackground())
1189 return false; 1184 return false;
1190 1185
1191 if (node() != document().firstBodyElement()) 1186 if (node() != document().firstBodyElement())
1192 return false; 1187 return false;
1193 1188
1194 return true; 1189 return true;
1195 } 1190 }
1196 1191
1197 } // namespace blink 1192 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698