Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2346883002:
Skip GLES2ConformTest.GL2FixedTests_buffer_color_input_run on debug (Closed)
|
Created:
4 years, 3 months ago by Geoff Lang Modified:
4 years, 3 months ago CC:
chromium-reviews, piman+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSkip GLES2ConformTest.GL2FixedTests_buffer_color_input_run on debug
This test doesn't run fast enough to always finish within the hard-coded 45 second time limit.
R=kbr@chromium.org
TBR=piman@chromium.org
BUG=646442
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/b03d43e3f56b003f1f0d890e8bcb35fa0ce7b5b2
Cr-Commit-Position: refs/heads/master@{#418996}
Patch Set 1 #Patch Set 2 : Fix expectation conflicts #Messages
Total messages: 18 (11 generated)
Description was changed from ========== Skip GLES2ConformTest.GL2FixedTests_buffer_color_input_run on debug This test doesn't run fast enough to always finish within the hard-coded 45 second time limit. BUG=646442 ========== to ========== Skip GLES2ConformTest.GL2FixedTests_buffer_color_input_run on debug This test doesn't run fast enough to always finish within the hard-coded 45 second time limit. BUG=646442 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Skip GLES2ConformTest.GL2FixedTests_buffer_color_input_run on debug This test doesn't run fast enough to always finish within the hard-coded 45 second time limit. BUG=646442 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Skip GLES2ConformTest.GL2FixedTests_buffer_color_input_run on debug This test doesn't run fast enough to always finish within the hard-coded 45 second time limit. R=kbr@chromium.org TBR=piman@chromium.org BUG=646442 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
geofflang@chromium.org changed reviewers: + kbr@chromium.org, piman@chromium.org
Ken: PTAL Antoine: PTAL/FYI
The CQ bit was checked by geofflang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Thanks. LGTM
lgtm
Apparently the linux bot didn't like something about the change, looking...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...) win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)
The CQ bit was checked by geofflang@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org, piman@chromium.org Link to the patchset: https://codereview.chromium.org/2346883002/#ps20001 (title: "Fix expectation conflicts")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Skip GLES2ConformTest.GL2FixedTests_buffer_color_input_run on debug This test doesn't run fast enough to always finish within the hard-coded 45 second time limit. R=kbr@chromium.org TBR=piman@chromium.org BUG=646442 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Skip GLES2ConformTest.GL2FixedTests_buffer_color_input_run on debug This test doesn't run fast enough to always finish within the hard-coded 45 second time limit. R=kbr@chromium.org TBR=piman@chromium.org BUG=646442 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Skip GLES2ConformTest.GL2FixedTests_buffer_color_input_run on debug This test doesn't run fast enough to always finish within the hard-coded 45 second time limit. R=kbr@chromium.org TBR=piman@chromium.org BUG=646442 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Skip GLES2ConformTest.GL2FixedTests_buffer_color_input_run on debug This test doesn't run fast enough to always finish within the hard-coded 45 second time limit. R=kbr@chromium.org TBR=piman@chromium.org BUG=646442 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/b03d43e3f56b003f1f0d890e8bcb35fa0ce7b5b2 Cr-Commit-Position: refs/heads/master@{#418996} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b03d43e3f56b003f1f0d890e8bcb35fa0ce7b5b2 Cr-Commit-Position: refs/heads/master@{#418996} |
