[DevTools] Do not toggle tree element if there is a selection.

[DevTools] Do not toggle tree element if there is a selection.

This prevents the toggling when user just wanted to select text.
Note that simple click usually clears the selection and element will be toggled.

BUG=none

Committed: https://crrev.com/569bccc198c32534e3855172fe95ab135574a991
Cr-Commit-Position: refs/heads/master@{#419353}

[dgozman, 2016-09-16 22:36:03]

Description was changed from

==========
[DevTools] Do not toggle tree element if there is a selection.

This prevents the toggling when user just wanted to select things.
Note that simple click usually clears selection, therefore tree element will be
toggled by click.

BUG=none
==========

to

==========
[DevTools] Do not toggle tree element if there is a selection.

This prevents the toggling when user just wanted to select text.
Note that simple click usually clears the selection and element will be toggled.

BUG=none
==========

[dgozman, 2016-09-16 22:39:52]

dgozman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[dgozman, 2016-09-16 22:39:53]

Could you please take a look?

[pfeldman, 2016-09-16 22:54:19]

https://codereview.chromium.org/2346873005/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js (right):

https://codereview.chromium.org/2346873005/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js:784: if
(element.treeElement !== this || element.hasSelection())
hasSelection returns true upon mouse down?

[dgozman, 2016-09-16 23:00:48]

https://codereview.chromium.org/2346873005/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js (right):

https://codereview.chromium.org/2346873005/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js:784: if
(element.treeElement !== this || element.hasSelection())
On 2016/09/16 22:54:18, pfeldman wrote:
> hasSelection returns true upon mouse down?

Correct.

[pfeldman, 2016-09-16 23:18:17]

lgtm

[dgozman, 2016-09-16 23:21:04]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-09-16 23:21:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-17 00:58:03]

Description was changed from

==========
[DevTools] Do not toggle tree element if there is a selection.

This prevents the toggling when user just wanted to select text.
Note that simple click usually clears the selection and element will be toggled.

BUG=none
==========

to

==========
[DevTools] Do not toggle tree element if there is a selection.

This prevents the toggling when user just wanted to select text.
Note that simple click usually clears the selection and element will be toggled.

BUG=none
==========

[commit-bot: I haz the power, 2016-09-17 00:58:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-17 01:00:35]

Description was changed from

==========
[DevTools] Do not toggle tree element if there is a selection.

This prevents the toggling when user just wanted to select text.
Note that simple click usually clears the selection and element will be toggled.

BUG=none
==========

to

==========
[DevTools] Do not toggle tree element if there is a selection.

This prevents the toggling when user just wanted to select text.
Note that simple click usually clears the selection and element will be toggled.

BUG=none

Committed: https://crrev.com/569bccc198c32534e3855172fe95ab135574a991
Cr-Commit-Position: refs/heads/master@{#419353}
==========

[commit-bot: I haz the power, 2016-09-17 01:00:37]

Patchset 1 (id:??) landed as
https://crrev.com/569bccc198c32534e3855172fe95ab135574a991
Cr-Commit-Position: refs/heads/master@{#419353}