Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: components/drive/resource_metadata_storage_unittest.cc

Issue 2346873004: Added 'starred' to EntryProperty in FileManagerPrivateAPI. (Closed)
Patch Set: Change tag name 'has_starred' into 'starred_property_initialized.' Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/drive/resource_metadata_storage_unittest.cc
diff --git a/components/drive/resource_metadata_storage_unittest.cc b/components/drive/resource_metadata_storage_unittest.cc
index 5f4a0fa089cc59e84d4a830b86346bd8b858afec..e71d120968c0cd2ef97f53408426d5664f18ef63 100644
--- a/components/drive/resource_metadata_storage_unittest.cc
+++ b/components/drive/resource_metadata_storage_unittest.cc
@@ -43,6 +43,21 @@ class ResourceMetadataStorageTest : public testing::Test {
EXPECT_EQ(FILE_ERROR_OK, storage_->PutHeader(header));
}
+ // Overwrites |storage_|'s starred_property_initialized.
+ void SetStarredPropertyInitialized(bool value) {
+ ResourceMetadataHeader header;
+ ASSERT_EQ(FILE_ERROR_OK, storage_->GetHeader(&header));
+ header.set_starred_property_initialized(value);
+ EXPECT_EQ(FILE_ERROR_OK, storage_->PutHeader(header));
+ }
+
+ // Get |storage_|'s starred_property_initialized.
+ void GetStarredPropertyInitialized(bool* value) {
hashimoto 2016/09/29 08:43:43 How about returning the value? bool GetStarredPr
harukam 2016/09/29 09:39:46 I chose passe-by-pointer like as GetLargestChanges
+ ResourceMetadataHeader header;
+ EXPECT_EQ(FILE_ERROR_OK, storage_->GetHeader(&header));
+ *value = header.starred_property_initialized();
+ }
+
bool CheckValidity() {
return storage_->CheckValidity();
}
@@ -634,5 +649,19 @@ TEST_F(ResourceMetadataStorageTest, CheckValidity) {
EXPECT_TRUE(CheckValidity());
}
+TEST_F(ResourceMetadataStorageTest, ChangeStarredPropertyInitialized) {
+ // Suppose 'Starred' property has not loaded.
+ bool starred_property_initialized = false;
+ SetStarredPropertyInitialized(starred_property_initialized);
+
+ // Close DB and reopen.
+ storage_.reset(new ResourceMetadataStorage(
+ temp_dir_.GetPath(), base::ThreadTaskRunnerHandle::Get().get()));
+ ASSERT_TRUE(storage_->Initialize());
+
+ GetStarredPropertyInitialized(&starred_property_initialized);
+ EXPECT_TRUE(starred_property_initialized);
hashimoto 2016/09/29 08:43:43 Please check that the largest changestamp becomes
harukam 2016/09/29 09:39:46 Done.
+}
+
} // namespace internal
} // namespace drive

Powered by Google App Engine
This is Rietveld 408576698