Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Side by Side Diff: components/drive/resource_entry_conversion_unittest.cc

Issue 2346873004: Added 'starred' to EntryProperty in FileManagerPrivateAPI. (Closed)
Patch Set: Added and modified comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/drive/resource_entry_conversion.h" 5 #include "components/drive/resource_entry_conversion.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "base/time/time.h" 8 #include "base/time/time.h"
9 #include "components/drive/drive.pb.h" 9 #include "components/drive/drive.pb.h"
10 #include "components/drive/drive_api_util.h" 10 #include "components/drive/drive_api_util.h"
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 std::string parent_resource_id; 49 std::string parent_resource_id;
50 EXPECT_TRUE(ConvertFileResourceToResourceEntry( 50 EXPECT_TRUE(ConvertFileResourceToResourceEntry(
51 file_resource, &entry, &parent_resource_id)); 51 file_resource, &entry, &parent_resource_id));
52 52
53 EXPECT_EQ(file_resource.title(), entry.title()); 53 EXPECT_EQ(file_resource.title(), entry.title());
54 EXPECT_EQ(file_resource.title(), entry.base_name()); 54 EXPECT_EQ(file_resource.title(), entry.base_name());
55 EXPECT_EQ(file_resource.file_id(), entry.resource_id()); 55 EXPECT_EQ(file_resource.file_id(), entry.resource_id());
56 EXPECT_EQ("", parent_resource_id); 56 EXPECT_EQ("", parent_resource_id);
57 57
58 EXPECT_FALSE(entry.deleted()); 58 EXPECT_FALSE(entry.deleted());
59 EXPECT_FALSE(entry.starred());
59 EXPECT_FALSE(entry.shared_with_me()); 60 EXPECT_FALSE(entry.shared_with_me());
60 EXPECT_FALSE(entry.shared()); 61 EXPECT_FALSE(entry.shared());
61 62
62 EXPECT_EQ(file_resource.modified_date().ToInternalValue(), 63 EXPECT_EQ(file_resource.modified_date().ToInternalValue(),
63 entry.file_info().last_modified()); 64 entry.file_info().last_modified());
64 // Last accessed value equal to 0 means that the file has never been viewed. 65 // Last accessed value equal to 0 means that the file has never been viewed.
65 EXPECT_EQ(0, entry.file_info().last_accessed()); 66 EXPECT_EQ(0, entry.file_info().last_accessed());
66 EXPECT_EQ(file_resource.created_date().ToInternalValue(), 67 EXPECT_EQ(file_resource.created_date().ToInternalValue(),
67 entry.file_info().creation_time()); 68 entry.file_info().creation_time());
68 69
(...skipping 29 matching lines...) Expand all
98 file_resource, &entry, &parent_resource_id)); 99 file_resource, &entry, &parent_resource_id));
99 100
100 EXPECT_EQ(file_resource.title(), entry.title()); 101 EXPECT_EQ(file_resource.title(), entry.title());
101 EXPECT_EQ(file_resource.title() + ".gdoc", 102 EXPECT_EQ(file_resource.title() + ".gdoc",
102 entry.base_name()); // The suffix added. 103 entry.base_name()); // The suffix added.
103 EXPECT_EQ(".gdoc", entry.file_specific_info().document_extension()); 104 EXPECT_EQ(".gdoc", entry.file_specific_info().document_extension());
104 EXPECT_EQ(file_resource.file_id(), entry.resource_id()); 105 EXPECT_EQ(file_resource.file_id(), entry.resource_id());
105 EXPECT_EQ("", parent_resource_id); 106 EXPECT_EQ("", parent_resource_id);
106 107
107 EXPECT_FALSE(entry.deleted()); 108 EXPECT_FALSE(entry.deleted());
109 EXPECT_FALSE(entry.starred());
108 EXPECT_FALSE(entry.shared_with_me()); 110 EXPECT_FALSE(entry.shared_with_me());
109 EXPECT_FALSE(entry.shared()); 111 EXPECT_FALSE(entry.shared());
110 112
111 EXPECT_EQ(file_resource.modified_date().ToInternalValue(), 113 EXPECT_EQ(file_resource.modified_date().ToInternalValue(),
112 entry.file_info().last_modified()); 114 entry.file_info().last_modified());
113 EXPECT_EQ(file_resource.last_viewed_by_me_date().ToInternalValue(), 115 EXPECT_EQ(file_resource.last_viewed_by_me_date().ToInternalValue(),
114 entry.file_info().last_accessed()); 116 entry.file_info().last_accessed());
115 EXPECT_EQ(file_resource.created_date().ToInternalValue(), 117 EXPECT_EQ(file_resource.created_date().ToInternalValue(),
116 entry.file_info().creation_time()); 118 entry.file_info().creation_time());
117 119
(...skipping 30 matching lines...) Expand all
148 file_resource, &entry, &parent_resource_id)); 150 file_resource, &entry, &parent_resource_id));
149 151
150 EXPECT_EQ(file_resource.title(), entry.title()); 152 EXPECT_EQ(file_resource.title(), entry.title());
151 EXPECT_EQ(file_resource.title(), entry.base_name()); 153 EXPECT_EQ(file_resource.title(), entry.base_name());
152 EXPECT_EQ(file_resource.file_id(), entry.resource_id()); 154 EXPECT_EQ(file_resource.file_id(), entry.resource_id());
153 // The parent resource ID should be obtained as this is a sub directory 155 // The parent resource ID should be obtained as this is a sub directory
154 // under a non-root directory. 156 // under a non-root directory.
155 EXPECT_EQ(parent.file_id(), parent_resource_id); 157 EXPECT_EQ(parent.file_id(), parent_resource_id);
156 158
157 EXPECT_FALSE(entry.deleted()); 159 EXPECT_FALSE(entry.deleted());
160 EXPECT_FALSE(entry.starred());
158 EXPECT_FALSE(entry.shared_with_me()); 161 EXPECT_FALSE(entry.shared_with_me());
159 EXPECT_FALSE(entry.shared()); 162 EXPECT_FALSE(entry.shared());
160 163
161 EXPECT_EQ(file_resource.modified_date().ToInternalValue(), 164 EXPECT_EQ(file_resource.modified_date().ToInternalValue(),
162 entry.file_info().last_modified()); 165 entry.file_info().last_modified());
163 EXPECT_EQ(file_resource.last_viewed_by_me_date().ToInternalValue(), 166 EXPECT_EQ(file_resource.last_viewed_by_me_date().ToInternalValue(),
164 entry.file_info().last_accessed()); 167 entry.file_info().last_accessed());
165 EXPECT_EQ(file_resource.created_date().ToInternalValue(), 168 EXPECT_EQ(file_resource.created_date().ToInternalValue(),
166 entry.file_info().creation_time()); 169 entry.file_info().creation_time());
167 170
(...skipping 18 matching lines...) Expand all
186 std::string parent_resource_id; 189 std::string parent_resource_id;
187 EXPECT_TRUE(ConvertFileResourceToResourceEntry( 190 EXPECT_TRUE(ConvertFileResourceToResourceEntry(
188 file_resource, &entry, &parent_resource_id)); 191 file_resource, &entry, &parent_resource_id));
189 192
190 EXPECT_EQ(file_resource.title(), entry.title()); 193 EXPECT_EQ(file_resource.title(), entry.title());
191 EXPECT_EQ(file_resource.title() + ".gdoc", entry.base_name()); 194 EXPECT_EQ(file_resource.title() + ".gdoc", entry.base_name());
192 EXPECT_EQ(file_resource.file_id(), entry.resource_id()); 195 EXPECT_EQ(file_resource.file_id(), entry.resource_id());
193 EXPECT_EQ("", parent_resource_id); 196 EXPECT_EQ("", parent_resource_id);
194 197
195 EXPECT_TRUE(entry.deleted()); // The document was deleted. 198 EXPECT_TRUE(entry.deleted()); // The document was deleted.
199 EXPECT_FALSE(entry.starred());
196 EXPECT_FALSE(entry.shared_with_me()); 200 EXPECT_FALSE(entry.shared_with_me());
197 EXPECT_FALSE(entry.shared()); 201 EXPECT_FALSE(entry.shared());
198 202
199 EXPECT_EQ(file_resource.modified_date().ToInternalValue(), 203 EXPECT_EQ(file_resource.modified_date().ToInternalValue(),
200 entry.file_info().last_modified()); 204 entry.file_info().last_modified());
201 EXPECT_EQ(file_resource.last_viewed_by_me_date().ToInternalValue(), 205 EXPECT_EQ(file_resource.last_viewed_by_me_date().ToInternalValue(),
202 entry.file_info().last_accessed()); 206 entry.file_info().last_accessed());
203 EXPECT_EQ(file_resource.created_date().ToInternalValue(), 207 EXPECT_EQ(file_resource.created_date().ToInternalValue(),
204 entry.file_info().creation_time()); 208 entry.file_info().creation_time());
205 209
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
286 EXPECT_EQ(change_resource.file_id(), entry.resource_id()); 290 EXPECT_EQ(change_resource.file_id(), entry.resource_id());
287 EXPECT_EQ("", parent_resource_id); 291 EXPECT_EQ("", parent_resource_id);
288 292
289 EXPECT_TRUE(entry.deleted()); 293 EXPECT_TRUE(entry.deleted());
290 294
291 EXPECT_EQ(change_resource.modification_date().ToInternalValue(), 295 EXPECT_EQ(change_resource.modification_date().ToInternalValue(),
292 entry.modification_date()); 296 entry.modification_date());
293 } 297 }
294 298
295 TEST(ResourceEntryConversionTest, 299 TEST(ResourceEntryConversionTest,
300 ConvertFileResourceToResourceEntry_StarredEntry) {
301 google_apis::FileResource file_resource;
302 file_resource.mutable_labels()->set_starred(true);
303
304 ResourceEntry entry;
305 std::string parent_resource_id;
306 EXPECT_TRUE(ConvertFileResourceToResourceEntry(
307 file_resource, &entry, &parent_resource_id));
308 EXPECT_TRUE(entry.starred());
309 }
310
311 TEST(ResourceEntryConversionTest,
296 ConvertFileResourceToResourceEntry_SharedWithMeEntry) { 312 ConvertFileResourceToResourceEntry_SharedWithMeEntry) {
297 google_apis::FileResource file_resource; 313 google_apis::FileResource file_resource;
298 file_resource.set_shared(true); 314 file_resource.set_shared(true);
299 file_resource.set_shared_with_me_date(GetTestTime()); 315 file_resource.set_shared_with_me_date(GetTestTime());
300 316
301 ResourceEntry entry; 317 ResourceEntry entry;
302 std::string parent_resource_id; 318 std::string parent_resource_id;
303 EXPECT_TRUE(ConvertFileResourceToResourceEntry( 319 EXPECT_TRUE(ConvertFileResourceToResourceEntry(
304 file_resource, &entry, &parent_resource_id)); 320 file_resource, &entry, &parent_resource_id));
305 EXPECT_TRUE(entry.shared_with_me()); 321 EXPECT_TRUE(entry.shared_with_me());
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
368 std::string parent_resource_id; 384 std::string parent_resource_id;
369 EXPECT_TRUE(ConvertFileResourceToResourceEntry( 385 EXPECT_TRUE(ConvertFileResourceToResourceEntry(
370 entry_no_fields, &entry, &parent_resource_id)); 386 entry_no_fields, &entry, &parent_resource_id));
371 EXPECT_FALSE(entry.file_specific_info().has_image_width()); 387 EXPECT_FALSE(entry.file_specific_info().has_image_width());
372 EXPECT_FALSE(entry.file_specific_info().has_image_height()); 388 EXPECT_FALSE(entry.file_specific_info().has_image_height());
373 EXPECT_FALSE(entry.file_specific_info().has_image_rotation()); 389 EXPECT_FALSE(entry.file_specific_info().has_image_rotation());
374 } 390 }
375 } 391 }
376 392
377 } // namespace drive 393 } // namespace drive
OLDNEW
« no previous file with comments | « components/drive/resource_entry_conversion.cc ('k') | components/drive/resource_metadata_storage.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698