Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2346863002: Add InvokeApiCallbackInterrupt runtime counter (Closed)

Created:
4 years, 3 months ago by Camillo Bruni
Modified:
4 years, 3 months ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add InvokeApiInterruptCallbacks runtime counter This was one of the paths inside StackGuard that lacked a runtime counter, making it hard to assess what was going on. BUG= Committed: https://crrev.com/8dd2160c14b7adbe98e418540aad6f1daf191715 Cr-Commit-Position: refs/heads/master@{#39455}

Patch Set 1 #

Patch Set 2 : copy pasta fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/counters.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/isolate.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Camillo Bruni
PTAL
4 years, 3 months ago (2016-09-15 16:31:57 UTC) #3
neis
lgtm
4 years, 3 months ago (2016-09-15 16:35:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2346863002/1
4 years, 3 months ago (2016-09-15 17:29:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/8770) v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED, ...
4 years, 3 months ago (2016-09-15 17:33:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2346863002/20001
4 years, 3 months ago (2016-09-15 18:29:56 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-15 18:56:16 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 18:56:47 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8dd2160c14b7adbe98e418540aad6f1daf191715
Cr-Commit-Position: refs/heads/master@{#39455}

Powered by Google App Engine
This is Rietveld 408576698