Add a DOM.getLayoutTreeNodes devtools command

third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

 /*
  * Copyright (C) 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2011 Google Inc. All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 48 matching lines @@
 #include "core/html/imports/HTMLImportChild.h"
 #include "core/html/imports/HTMLImportLoader.h"
 #include "core/inspector/DOMEditor.h"
 #include "core/inspector/DOMPatchSupport.h"
 #include "core/inspector/IdentifiersFactory.h"
 #include "core/inspector/InspectedFrames.h"
 #include "core/inspector/InspectorHighlight.h"
 #include "core/inspector/InspectorHistory.h"
 #include "core/inspector/V8InspectorString.h"
 #include "core/layout/HitTestResult.h"
+#include "core/layout/LayoutInline.h"
 #include "core/layout/api/LayoutViewItem.h"
+#include "core/layout/line/InlineTextBox.h"
 #include "core/loader/DocumentLoader.h"
 #include "core/page/FrameTree.h"
 #include "core/page/Page.h"
 #include "core/xml/DocumentXPathEvaluator.h"
 #include "core/xml/XPathResult.h"
 #include "platform/PlatformGestureEvent.h"
 #include "platform/PlatformMouseEvent.h"
 #include "platform/PlatformTouchEvent.h"
 #include "wtf/ListHashSet.h"
 #include "wtf/PtrUtil.h"
@@ skipping 441 matching lines @@
     if (!m_document) {
         *errorString = "Document is not available";
         return;
     }
 
     discardFrontendBindings();
 
     *root = buildObjectForNode(m_document.get(), 2, m_documentNodeToIdMap.get());
 }
 
+namespace {
+std::unique_ptr<protocol::DOM::Rect> getRectForFloatRect(const FloatRect& rect)

[pfeldman, 2016/09/16 00:59:35]

We call these build*. Also, either move those to the top of the file or drop the
namespace and use static modifiers.

[alex clarke (OOO till 29th), 2016/09/16 10:23:36]

Done.

+{
+    return protocol::DOM::Rect::create()
+        .setX(rect.x())
+        .setY(rect.y())
+        .setWidth(rect.width())
+        .setHeight(rect.height())
+        .build();
+}
+
+FloatRect getAbsoluteBoundingBox(LayoutObject* layoutObject)

[pfeldman, 2016/09/16 00:59:35]

Blink does not (yet) use get prefixes.

[alex clarke (OOO till 29th), 2016/09/16 10:23:36]

Done.

+{
+    if (layoutObject->isText()) {
+        FloatRect localRect(toLayoutText(layoutObject)->linesBoundingBox());
+        return layoutObject->localToAbsoluteQuad(localRect).boundingBox();

[pfeldman, 2016/09/16 00:59:35]

I am not sure this matches your expectations wrt coordinate system, but you'll
know better once you apply it. Make sure you checked it for the iframes,
scrolled iframes, etc.

[alex clarke (OOO till 29th), 2016/09/16 10:23:36]

Acknowledged.

+    }
+    if (layoutObject->isLayoutInline()) {
+        FloatRect localRect(toLayoutInline(layoutObject)->linesBoundingBox());
+        return layoutObject->localToAbsoluteQuad(localRect).boundingBox();
+    }
+    if (layoutObject->isBox()) {
+        FloatRect localRect(toLayoutBox(layoutObject)->borderBoxRect());
+        return layoutObject->localToAbsoluteQuad(localRect).boundingBox();
+    }
+    return layoutObject->absoluteBoundingBoxRect();
+}
+
+} // namespace
+
+void InspectorDOMAgent::getRenderTreeNodes(ErrorString* errorString, std::unique_ptr<protocol::Array<protocol::DOM::RenderTreeNode>>* renderTreeNodes)
+{
+    renderTreeNodes->reset(new protocol::Array<protocol::DOM::RenderTreeNode>);
+
+    std::vector<Node*> unvisited; // Neither WTF::Vector or HeapVector allow Node* :(
+    unvisited.push_back(m_document.get());
+
+    while (!unvisited.empty()) {
+        Node* node = unvisited.back();
+        unvisited.pop_back();
+        LayoutObject* layoutObject = node->layoutObject();
+        if (!layoutObject)

[pfeldman, 2016/09/16 00:59:35]

You still might want to go over the dom hierarchy.

[alex clarke (OOO till 29th), 2016/09/16 10:23:36]

Good point!

+            continue;
+
+        int backendNodeId = DOMNodeIds::idForNode(node);
+        DCHECK(backendNodeId);

[pfeldman, 2016/09/16 00:59:35]

It is always there

[alex clarke (OOO till 29th), 2016/09/16 10:23:36]

Done.

+        std::unique_ptr<protocol::DOM::RenderTreeNode> renderTreeNode =
+            protocol::DOM::RenderTreeNode::create()
+                .setBackendNodeId(backendNodeId)
+                .setBoundingBox(getRectForFloatRect(getAbsoluteBoundingBox(layoutObject)))
+                .build();
+
+        if (layoutObject->isText()) {
+            LayoutText* layoutText = toLayoutText(layoutObject);
+            renderTreeNode->setLayoutText(layoutText->text());
+            if (layoutText->hasTextBoxes()) {
+                std::unique_ptr<protocol::Array<protocol::DOM::InlineTextBox>> inlineTextNodes(new protocol::Array<protocol::DOM::InlineTextBox>());
+                for (const InlineTextBox* itb = layoutText->firstTextBox(); itb; itb = itb->nextTextBox()) {
+                    FloatRect localItbRect(itb->calculateBoundaries());
+                    FloatRect absoluteItbRect = layoutObject->localToAbsoluteQuad(localItbRect).boundingBox();
+                    inlineTextNodes->addItem(
+                        protocol::DOM::InlineTextBox::create()
+                            .setText(layoutText->text().substring(itb->start(), itb->len()).utf8().data())
+                            .setBoundingBox(getRectForFloatRect(absoluteItbRect))
+                            .build());
+                }
+                renderTreeNode->setInlineTextNodes(std::move(inlineTextNodes));
+            }
+        }
+
+        (*renderTreeNodes)->addItem(std::move(renderTreeNode));
+
+        for (node = innerFirstChild(node); node; node = innerNextSibling(node))

[pfeldman, 2016/09/16 00:59:35]

I don't see where you account for the shadow dom. Also, this seems to be an
array of layout objects for nodes rather than the render tree. Didn't you want
to traverse the render tree instead?

[alex clarke (OOO till 29th), 2016/09/16 10:23:36]

Hopefully I've done that now.
I'm under the impression that we don't want to traverse the render tree. 
Perhaps we should discuss this offline?

+            unvisited.push_back(node);
+    }
+}
+
 void InspectorDOMAgent::pushChildNodesToFrontend(int nodeId, int depth)
 {
     Node* node = nodeForId(nodeId);
     if (!node || (!node->isElementNode() && !node->isDocumentNode() && !node->isDocumentFragment()))
         return;
 
     NodeToIdMap* nodeMap = m_idToNodesMap.get(nodeId);
 
     if (m_childrenRequested.contains(nodeId)) {
         if (depth <= 1)
@@ skipping 1560 matching lines @@
     visitor->trace(m_idToNodesMap);
     visitor->trace(m_document);
     visitor->trace(m_revalidateTask);
     visitor->trace(m_searchResults);
     visitor->trace(m_history);
     visitor->trace(m_domEditor);
     InspectorBaseAgent::trace(visitor);
 }
 
 } // namespace blink