Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 2346833003: cros: Hide stylus tools on various sign-in screens, disable active mode when inserting stylus. (Closed)

Created:
4 years, 3 months ago by jdufault
Modified:
4 years, 3 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Hide stylus tools on various sign-in screens, disable active mode when inserting stylus. The stylus tools would be shown previous when adding a supervised user. They could also be shown by ejecting the stylus at any point. This CL also causes the active mode to turn off when the user inserts the stylus. BUG=647025 Committed: https://crrev.com/5a91b4847459c8f07696fed2fdce9cd55b6cd58d Cr-Commit-Position: refs/heads/master@{#419278}

Patch Set 1 #

Patch Set 2 : Initial upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -16 lines) Patch
M ash/common/system/chromeos/palette/palette_tool_manager.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ash/common/system/chromeos/palette/palette_tool_manager.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M ash/common/system/chromeos/palette/palette_tray.cc View 1 3 chunks +38 lines, -16 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
jdufault
Oshima, PTAL. Thanks!
4 years, 3 months ago (2016-09-16 18:46:35 UTC) #11
oshima
lgtm
4 years, 3 months ago (2016-09-16 20:35:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2346833003/20001
4 years, 3 months ago (2016-09-16 20:43:39 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-16 20:48:53 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 20:51:29 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5a91b4847459c8f07696fed2fdce9cd55b6cd58d
Cr-Commit-Position: refs/heads/master@{#419278}

Powered by Google App Engine
This is Rietveld 408576698