Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2346823002: Forward return value of PostTaskToTaskScheduler() to PostTask() in SequencedWorkerPool. (Closed)

Created:
4 years, 3 months ago by fdoray
Modified:
4 years, 3 months ago
Reviewers:
robliao, danakj, gab
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Forward return value of PostTaskToTaskScheduler() to PostTask() in SequencedWorkerPool. With this CL, SequencedWorkerPool::Inner::PostTask (and hence all task posting APIs associated with SequencedWorkerPool) returns false when redirection to TaskScheduler is enabled and the posted task definitely will not run. BUG=622400 Committed: https://crrev.com/5cea1b0cf4328831e583fa66f9fa30c8d075d677 Cr-Commit-Position: refs/heads/master@{#418939}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M base/threading/sequenced_worker_pool.cc View 4 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
fdoray
PTAL
4 years, 3 months ago (2016-09-15 15:10:30 UTC) #2
robliao
lgtm
4 years, 3 months ago (2016-09-15 15:15:53 UTC) #3
fdoray
danakj@: PTAL
4 years, 3 months ago (2016-09-15 15:18:37 UTC) #5
gab
lgtm
4 years, 3 months ago (2016-09-15 16:36:06 UTC) #6
fdoray
danakj@: PTAL
4 years, 3 months ago (2016-09-15 16:42:55 UTC) #7
danakj
LGTM Worth testing?
4 years, 3 months ago (2016-09-15 18:36:33 UTC) #8
fdoray
On 2016/09/15 18:36:33, danakj wrote: > LGTM > > Worth testing? Will be tested by ...
4 years, 3 months ago (2016-09-15 18:41:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2346823002/1
4 years, 3 months ago (2016-09-15 18:42:25 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 19:59:20 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 20:01:55 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5cea1b0cf4328831e583fa66f9fa30c8d075d677
Cr-Commit-Position: refs/heads/master@{#418939}

Powered by Google App Engine
This is Rietveld 408576698