Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Issue 2346813003: Add compatibility shims to libsrtp for v1->v2 transition (Closed)

Created:
4 years, 3 months ago by mattdr-at-chromium
Modified:
4 years, 2 months ago
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add compatibility shims to libsrtp for v1->v2 transition This essentially creates libsrtp 1.9, with #defines to allow both 'identifier' and 'srtp_identifier' for the symbols used by WebRTC. Then we can change WebRTC to use the new symbols and replace this with libsrtp 2.0. Add an OWNERS file. BUG=webrtc:6376 R=kjellander@chromium.org, phoglund@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/libsrtp/+/b17c065a8a63725eca216fd461984f82c331dd07

Patch Set 1 #

Patch Set 2 : Add OWNERS #

Patch Set 3 : Add kjellander #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -0 lines) Patch
A OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M srtp/crypto/include/err.h View 1 chunk +34 lines, -0 lines 0 comments Download
M srtp/crypto/include/rdbx.h View 1 chunk +6 lines, -0 lines 0 comments Download
M srtp/include/srtp.h View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
mattdr-at-chromium
4 years, 3 months ago (2016-09-16 18:34:48 UTC) #4
mattdr-at-chromium
On 2016/09/16 18:34:48, mattdr-at-chromium wrote: Trybots weren't applicable here. This change will be verified when ...
4 years, 3 months ago (2016-09-16 18:45:31 UTC) #5
mattdr-at-chromium
Henrik, mind taking a look? Thanks.
4 years, 3 months ago (2016-09-20 19:20:13 UTC) #7
kjellander_chromium
lgtm, although I'm not very familiar with this. Maybe deadbeef@ or pthatcher@ can provide more ...
4 years, 3 months ago (2016-09-20 20:15:56 UTC) #8
kjellander_chromium
On 2016/09/20 20:15:56, kjellander_chromium wrote: > lgtm, although I'm not very familiar with this. Maybe ...
4 years, 3 months ago (2016-09-20 20:16:32 UTC) #9
phoglund_chromium
lgtm
4 years, 2 months ago (2016-09-26 13:11:46 UTC) #10
mattdr-at-chromium
I don't have Chromium commit access. Better for one of you two to land this, ...
4 years, 2 months ago (2016-09-26 21:04:53 UTC) #11
kjellander_chromium
Committed patchset #3 (id:40001) manually as b17c065a8a63725eca216fd461984f82c331dd07 (presubmit successful).
4 years, 2 months ago (2016-09-27 06:40:48 UTC) #13
kjellander_chromium
On 2016/09/26 21:04:53, mattdr-at-chromium wrote: > I don't have Chromium commit access. Better for one ...
4 years, 2 months ago (2016-09-27 06:41:10 UTC) #14
kjellander_chromium
4 years, 2 months ago (2016-09-27 06:42:09 UTC) #15
Message was sent while issue was closed.
On 2016/09/27 06:41:10, kjellander_chromium wrote:
> On 2016/09/26 21:04:53, mattdr-at-chromium wrote:
> > I don't have Chromium commit access. Better for one of you two to land this,
> or
> > better for me to ask for commit access?
> 
> No problem, I just landed it.

Will you take care of rolling it into Chromium's DEPS though? The new revision
is here:
https://chromium.googlesource.com/chromium/deps/libsrtp.git/+/b17c065a8a63725...

Powered by Google App Engine
This is Rietveld 408576698