Add histograms for script execution time for doc write observer

chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc

Index: chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc
index 5a8ce3b903762f6bf06f7186cf674b05ded3b7ae..9083e29271eb1b8425b396bdf6462ab366d50bb4 100644
--- a/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc
@@ -84,18 +84,25 @@ const char kHistogramDocWriteParseStartToFirstContentfulPaintImmediate[] =
     "ParseStartToFirstContentfulPaint";
 const char kHistogramDocWriteParseDurationImmediate[] =
     "PageLoad.Clients.DocWrite.Evaluator.ParseTiming.ParseDuration";
-const char kHistogramDocWriteParseBlockedOnScriptImmediate[] =
+const char kHistogramDocWriteParseBlockedOnScriptLoadImmediate[] =
     "PageLoad.Clients.DocWrite.Evaluator.ParseTiming.ParseBlockedOnScriptLoad";
 const char kHistogramDocWriteParseBlockedOnScriptLoadDocumentWriteImmediate[] =
     "PageLoad.Clients.DocWrite.Evaluator.ParseTiming."
     "ParseBlockedOnScriptLoadFromDocumentWrite";
+const char kHistogramDocWriteParseBlockedOnScriptExecutionImmediate[] =
+    "PageLoad.Clients.DocWrite.Evaluator.ParseTiming."
+    "ParseBlockedOnScriptExecution";
+const char
+    kHistogramDocWriteParseBlockedOnScriptExecutionDocumentWriteImmediate[] =
+        "PageLoad.Clients.DocWrite.Evaluator.ParseTiming."
+        "ParseBlockedOnScriptExecutionFromDocumentWrite";
 const char kBackgroundHistogramDocWriteFirstContentfulPaintImmediate[] =
     "PageLoad.Clients.DocWrite.Evaluator.PaintTiming."
     "NavigationToFirstContentfulPaint."
     "Background";
 const char kBackgroundHistogramDocWriteParseDurationImmediate[] =
     "PageLoad.Clients.DocWrite.Evaluator.ParseTiming.ParseDuration.Background";
-const char kBackgroundHistogramDocWriteParseBlockedOnScriptImmediate[] =
+const char kBackgroundHistogramDocWriteParseBlockedOnScriptLoadImmediate[] =
     "PageLoad.Clients.DocWrite.Evaluator.ParseTiming.ParseBlockedOnScriptLoad."
     "Background";
 const char
@@ -109,18 +116,25 @@ const char kHistogramDocWriteBlockFirstContentfulPaintImmediate[] =
 const char kHistogramDocWriteBlockParseStartToFirstContentfulPaintImmediate[] =
     "PageLoad.Clients.DocWrite.Block.PaintTiming."
     "ParseStartToFirstContentfulPaint";
-const char kHistogramDocWriteBlockParseBlockedOnScriptImmediate[] =
+const char kHistogramDocWriteBlockParseBlockedOnScriptLoadImmediate[] =
     "PageLoad.Clients.DocWrite.Block.ParseTiming.ParseBlockedOnScriptLoad";
 const char
     kHistogramDocWriteBlockParseBlockedOnScriptLoadDocumentWriteImmediate[] =
         "PageLoad.Clients.DocWrite.Block.ParseTiming."
         "ParseBlockedOnScriptLoadFromDocumentWrite";
+const char kHistogramDocWriteBlockParseBlockedOnScriptExecutionImmediate[] =
+    "PageLoad.Clients.DocWrite.Block.ParseTiming.ParseBlockedOnScriptExecution";
+const char
+    kHistogramDocWriteBlockParseBlockedOnScriptExecutionDocumentWriteImmediate
+        [] = "PageLoad.Clients.DocWrite.Block.ParseTiming."
+             "ParseBlockedOnScriptExecutionFromDocumentWrite";

[Charlie Harrison, 2016/09/15 15:28:59]

Have we dug ourselves into a hole of long histogram names with no way out?

[Bryan McQuade, 2016/09/15 15:44:24]

Yeah, I think these histograms are sufficiently specific that they require long
names. It's not clear to me how to make these much shorter without losing
important information in the histogram name.

That said, it's only these 'leaf' histograms, that track specific information
for a subset of page loads, that have to be this long. The core histograms are
shorter, as they should be.

 const char kHistogramDocWriteBlockParseDurationImmediate[] =
     "PageLoad.Clients.DocWrite.Block.ParseTiming.ParseDuration";
 
-const char kBackgroundHistogramDocWriteBlockParseBlockedOnScriptImmediate[] =
-    "PageLoad.Clients.DocWrite.Block.ParseTiming.ParseBlockedOnScriptLoad."
-    "Background";
+const char
+    kBackgroundHistogramDocWriteBlockParseBlockedOnScriptLoadImmediate[] =
+        "PageLoad.Clients.DocWrite.Block.ParseTiming.ParseBlockedOnScriptLoad."
+        "Background";
 const char
     kBackgroundDocWriteBlockParseBlockedOnScriptLoadDocumentWriteImmediate[] =
         "PageLoad.Clients.DocWrite.Block.ParseTiming."
@@ -262,19 +276,27 @@ void DocumentWritePageLoadMetricsObserver::LogDocumentWriteEvaluatorParseStop(
     PAGE_LOAD_HISTOGRAM(internal::kHistogramDocWriteParseDurationImmediate,
                         parse_duration);
     PAGE_LOAD_HISTOGRAM(
-        internal::kHistogramDocWriteParseBlockedOnScriptImmediate,
+        internal::kHistogramDocWriteParseBlockedOnScriptLoadImmediate,
         timing.parse_blocked_on_script_load_duration.value());
     PAGE_LOAD_HISTOGRAM(
         internal::
             kHistogramDocWriteParseBlockedOnScriptLoadDocumentWriteImmediate,
         timing.parse_blocked_on_script_load_from_document_write_duration
             .value());
+    PAGE_LOAD_HISTOGRAM(
+        internal::kHistogramDocWriteParseBlockedOnScriptExecutionImmediate,
+        timing.parse_blocked_on_script_execution_duration.value());
+    PAGE_LOAD_HISTOGRAM(
+        internal::
+            kHistogramDocWriteParseBlockedOnScriptExecutionDocumentWriteImmediate,
+        timing.parse_blocked_on_script_execution_from_document_write_duration
+            .value());
   } else {
     PAGE_LOAD_HISTOGRAM(
         internal::kBackgroundHistogramDocWriteParseDurationImmediate,
         parse_duration);
     PAGE_LOAD_HISTOGRAM(
-        internal::kBackgroundHistogramDocWriteParseBlockedOnScriptImmediate,
+        internal::kBackgroundHistogramDocWriteParseBlockedOnScriptLoadImmediate,
         timing.parse_blocked_on_script_load_duration.value());
     PAGE_LOAD_HISTOGRAM(
         internal::
@@ -379,20 +401,28 @@ void DocumentWritePageLoadMetricsObserver::LogDocumentWriteBlockParseStop(
     PAGE_LOAD_HISTOGRAM(internal::kHistogramDocWriteBlockParseDurationImmediate,
                         parse_duration);
     PAGE_LOAD_HISTOGRAM(
-        internal::kHistogramDocWriteBlockParseBlockedOnScriptImmediate,
+        internal::kHistogramDocWriteBlockParseBlockedOnScriptLoadImmediate,
         timing.parse_blocked_on_script_load_duration.value());
     PAGE_LOAD_HISTOGRAM(
         internal::
             kHistogramDocWriteBlockParseBlockedOnScriptLoadDocumentWriteImmediate,
         timing.parse_blocked_on_script_load_from_document_write_duration
             .value());
+    PAGE_LOAD_HISTOGRAM(
+        internal::kHistogramDocWriteBlockParseBlockedOnScriptExecutionImmediate,
+        timing.parse_blocked_on_script_execution_duration.value());
+    PAGE_LOAD_HISTOGRAM(
+        internal::
+            kHistogramDocWriteBlockParseBlockedOnScriptExecutionDocumentWriteImmediate,
+        timing.parse_blocked_on_script_execution_from_document_write_duration
+            .value());
   } else {
     PAGE_LOAD_HISTOGRAM(
         internal::kBackgroundHistogramDocWriteBlockParseDurationImmediate,
         parse_duration);
     PAGE_LOAD_HISTOGRAM(
         internal::
-            kBackgroundHistogramDocWriteBlockParseBlockedOnScriptImmediate,
+            kBackgroundHistogramDocWriteBlockParseBlockedOnScriptLoadImmediate,
         timing.parse_blocked_on_script_load_duration.value());
     PAGE_LOAD_HISTOGRAM(
         internal::