Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1156)

Issue 2346803005: Remove use of shared messages (Closed)

Created:
4 years, 3 months ago by Brian Wilkerson
Modified:
4 years, 3 months ago
Reviewers:
floitsch, scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -246 lines) Patch
M pkg/analyzer/lib/src/error/codes.dart View 24 chunks +70 lines, -35 lines 0 comments Download
D pkg/analyzer/lib/src/generated/generated/shared_messages.dart View 1 chunk +0 lines, -193 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 3 chunks +46 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 3 months ago (2016-09-16 17:38:30 UTC) #2
scheglov
LGTM
4 years, 3 months ago (2016-09-16 17:50:28 UTC) #3
Brian Wilkerson
4 years, 3 months ago (2016-09-20 15:25:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3c865fa6b56675fbd4ee36b19463ea83bfbcfd99 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698