Issue 2346803002: Remove ricow@ from failure print out

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2346803002: Remove ricow@ from failure print out (Closed)

Created:
4 years, 3 months ago by ricow1

Modified:
4 years, 3 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	tools/bots/linux_distribution_support.py	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
	M	tools/testing/dart/test_runner.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (2 generated)

Bill Hesse

LGTM. There are also two cases in tools/bots/linux_distribution_support that you should remove.

4 years, 3 months ago (2016-09-15 13:51:58 UTC) #3

ricow1

On 2016/09/15 13:51:58, Bill Hesse wrote: > LGTM. There are also two cases in tools/bots/linux_distribution_support ...

4 years, 3 months ago (2016-09-15 13:57:03 UTC) #4

ricow1

4 years, 3 months ago (2016-09-15 14:05:57 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
c1efad95c44aa257ce5b570e16520f2ba4592303 (presubmit successful).