Allow fragments to resolve relatively against any scheme

url/url_util_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/url_canon.h"
 #include "url/url_canon_stdstring.h"
 #include "url/url_parse.h"
 #include "url/url_test_utils.h"
 #include "url/url_util.h"
@@ skipping 252 matching lines @@
       // Resolving an absolute URL doesn't cause canonicalization of the
       // result.
     {"about:blank", "custom://Authority", true, "custom://Authority"},
       // Fragment URLs can be resolved against a non-standard base.
     {"scheme://Authority/path", "#fragment", true,
       "scheme://Authority/path#fragment"},
     {"scheme://Authority/", "#fragment", true, "scheme://Authority/#fragment"},
       // Resolving should fail if the base URL is authority-based but is
       // missing a path component (the '/' at the end).
     {"scheme://Authority", "path", false, ""},
+      // Test resolving a fragment (only) against any kind of base-URL.
+    {"about:blank", "#id42", true, "about:blank#id42" },
+    {"about:blank#oldfrag", "#newfrag", true, "about:blank#newfrag" },
+      // An unfortunate side effect of allowing fragments to resolve against
+      // any URL scheme is we might break javascript: URLs by doing so...
+    {"javascript:alert('foo#bar')", "#badfrag", true,
+      "javascript:alert('foo#badfrag" },

[mkosiba (inactive), 2013/08/27 20:55:56]

out of curiousity - what would KURL do in this case?

   };
 
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(resolve_non_standard_cases); i++) {
     const ResolveRelativeCase& test_data = resolve_non_standard_cases[i];
     url_parse::Parsed base_parsed;
     url_parse::ParsePathURL(test_data.base, strlen(test_data.base),
                             &base_parsed);
 
     std::string resolved;
     url_canon::StdStringCanonOutput output(&resolved);
     url_parse::Parsed resolved_parsed;
     bool valid =
         url_util::ResolveRelative(test_data.base, strlen(test_data.base),
                                   base_parsed,
                                   test_data.rel, strlen(test_data.rel),
                                   NULL, &output, &resolved_parsed);
     output.Complete();
 
     EXPECT_EQ(test_data.is_valid, valid) << i;
     if (test_data.is_valid && valid)
       EXPECT_EQ(test_data.out, resolved) << i;
   }
 }