Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Unified Diff: chrome/browser/ui/cocoa/l10n_util.h

Issue 2346783002: mac rtl: pin profile switcher to left edge in rtl (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/framed_browser_window.mm ('k') | chrome/browser/ui/cocoa/l10n_util.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/l10n_util.h
diff --git a/chrome/browser/ui/cocoa/l10n_util.h b/chrome/browser/ui/cocoa/l10n_util.h
index 3eb5fe186fa60f8161f45b3c2c724dbd0ef91ee6..8274916746ba23bea8e0c10241f47309390e319c 100644
--- a/chrome/browser/ui/cocoa/l10n_util.h
+++ b/chrome/browser/ui/cocoa/l10n_util.h
@@ -33,8 +33,12 @@ NSString* ReplaceNSStringPlaceholders(NSString* formatString,
// Generates a tooltip string for a given URL and title.
NSString* TooltipForURLAndTitle(NSString* url, NSString* title);
-// Returns whether experimental Mac RTL support is enabled via
-// --enable-features=ExperimentalMacRTL.
+// Returns whether both:
+// 1) Experimental Mac RTL support is enabled via the ExperimentalMacRTL
+// feature;
+// 2) The browser UI is in RTL mode.
Mark Mentovai 2016/09/15 13:46:11 The name of the function doesn’t indicate that it
Elly Fong-Jones 2016/09/16 12:56:45 Renamed it to ShouldDoExperimentalRTLLayout.
+// If ExperimentalMacRTL becomes the default, this function can be replaced with
+// uses of base::i18n::IsRTL().
bool ExperimentalMacRTLIsEnabled();
} // namespace cocoa_l10n_util
« no previous file with comments | « chrome/browser/ui/cocoa/framed_browser_window.mm ('k') | chrome/browser/ui/cocoa/l10n_util.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698