Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Side by Side Diff: src/code-stubs.cc

Issue 2346743003: [ic] Remove xxxIC_MissFromStubFailure runtime functions. (Closed)
Patch Set: Addressing comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/ic/ic.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/code-stubs.h" 5 #include "src/code-stubs.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "src/ast/ast.h" 9 #include "src/ast/ast.h"
10 #include "src/bootstrapper.h" 10 #include "src/bootstrapper.h"
(...skipping 5183 matching lines...) Expand 10 before | Expand all | Expand 10 after
5194 5194
5195 5195
5196 void KeyedLoadGenericStub::InitializeDescriptor( 5196 void KeyedLoadGenericStub::InitializeDescriptor(
5197 CodeStubDescriptor* descriptor) { 5197 CodeStubDescriptor* descriptor) {
5198 descriptor->Initialize( 5198 descriptor->Initialize(
5199 Runtime::FunctionForId(Runtime::kKeyedGetProperty)->entry); 5199 Runtime::FunctionForId(Runtime::kKeyedGetProperty)->entry);
5200 } 5200 }
5201 5201
5202 5202
5203 void HandlerStub::InitializeDescriptor(CodeStubDescriptor* descriptor) { 5203 void HandlerStub::InitializeDescriptor(CodeStubDescriptor* descriptor) {
5204 if (kind() == Code::STORE_IC) { 5204 DCHECK(kind() == Code::LOAD_IC || kind() == Code::KEYED_LOAD_IC);
5205 descriptor->Initialize(FUNCTION_ADDR(Runtime_StoreIC_MissFromStubFailure)); 5205 if (kind() == Code::KEYED_LOAD_IC) {
5206 } else if (kind() == Code::KEYED_LOAD_IC) {
5207 descriptor->Initialize( 5206 descriptor->Initialize(
5208 FUNCTION_ADDR(Runtime_KeyedLoadIC_MissFromStubFailure)); 5207 FUNCTION_ADDR(Runtime_KeyedLoadIC_MissFromStubFailure));
5209 } else if (kind() == Code::KEYED_STORE_IC) {
5210 descriptor->Initialize(
5211 FUNCTION_ADDR(Runtime_KeyedStoreIC_MissFromStubFailure));
5212 } 5208 }
5213 } 5209 }
5214 5210
5215 5211
5216 CallInterfaceDescriptor HandlerStub::GetCallInterfaceDescriptor() const { 5212 CallInterfaceDescriptor HandlerStub::GetCallInterfaceDescriptor() const {
5217 if (kind() == Code::LOAD_IC || kind() == Code::KEYED_LOAD_IC) { 5213 if (kind() == Code::LOAD_IC || kind() == Code::KEYED_LOAD_IC) {
5218 return LoadWithVectorDescriptor(isolate()); 5214 return LoadWithVectorDescriptor(isolate());
5219 } else { 5215 } else {
5220 DCHECK(kind() == Code::STORE_IC || kind() == Code::KEYED_STORE_IC); 5216 DCHECK(kind() == Code::STORE_IC || kind() == Code::KEYED_STORE_IC);
5221 return StoreWithVectorDescriptor(isolate()); 5217 return StoreWithVectorDescriptor(isolate());
(...skipping 1086 matching lines...) Expand 10 before | Expand all | Expand 10 after
6308 6304
6309 if (type == MachineType::Pointer()) { 6305 if (type == MachineType::Pointer()) {
6310 return Representation::External(); 6306 return Representation::External();
6311 } 6307 }
6312 6308
6313 return Representation::Tagged(); 6309 return Representation::Tagged();
6314 } 6310 }
6315 6311
6316 } // namespace internal 6312 } // namespace internal
6317 } // namespace v8 6313 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/ic/ic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698