Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2346743003:
[ic] Remove xxxIC_MissFromStubFailure runtime functions. (Closed)
|
Created:
4 years, 3 months ago by Igor Sheludko Modified:
4 years, 3 months ago Reviewers:
Toon Verwaest CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[ic] Remove unused xxxIC_MissFromStubFailure runtime functions.
Namely:
Runtime_LoadIC_MissFromStubFailure
Runtime_StoreIC_MissFromStubFailure
Runtime_KeyedStoreIC_MissFromStubFailure
BUG=chromium:608675
Committed: https://crrev.com/914519dda779322e378ae5e497b9e97cc3ffb71a
Cr-Commit-Position: refs/heads/master@{#39675}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Addressing comments #
Messages
Total messages: 28 (21 generated)
The CQ bit was checked by ishell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/12819)
Patchset #1 (id:1) has been deleted
The CQ bit was checked by ishell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #1 (id:20001) has been deleted
Description was changed from ========== [ic] Remove XXXStoreIC_MissFromStubFailure runtime functions. BUG=v8:5269 ========== to ========== [ic] Remove unused XXXStoreIC_MissFromStubFailure runtime functions. BUG=v8:5269 ==========
Description was changed from ========== [ic] Remove unused XXXStoreIC_MissFromStubFailure runtime functions. BUG=v8:5269 ========== to ========== [ic] Remove unused XXXStoreIC_MissFromStubFailure runtime functions. BUG=chromium:608675 ==========
Description was changed from ========== [ic] Remove unused XXXStoreIC_MissFromStubFailure runtime functions. BUG=chromium:608675 ========== to ========== [ic] Remove unused xxxIC_MissFromStubFailure runtime functions. Namely: Runtime_LoadIC_MissFromStubFailure Runtime_StoreIC_MissFromStubFailure Runtime_KeyedStoreIC_MissFromStubFailure BUG=chromium:608675 ==========
The CQ bit was checked by ishell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
ishell@chromium.org changed reviewers: + verwaest@chromium.org
PTAL
Patchset #1 (id:40001) has been deleted
lgtm https://codereview.chromium.org/2346743003/diff/60001/src/code-stubs.cc File src/code-stubs.cc (right): https://codereview.chromium.org/2346743003/diff/60001/src/code-stubs.cc#newco... src/code-stubs.cc:5204: if (kind() == Code::KEYED_LOAD_IC) { Shouldn't this by now just be DCHECK_EQ(Code::KEYED_LOAD_IC, kind()) ? https://codereview.chromium.org/2346743003/diff/60001/src/code-stubs.cc#newco... src/code-stubs.cc:5208: DCHECK(kind() != Code::STORE_IC && kind() != Code::KEYED_STORE_IC); DCHECK_NE(Code::STORE_IC, kind()); DCHECK_NE(...)
https://codereview.chromium.org/2346743003/diff/60001/src/code-stubs.cc File src/code-stubs.cc (right): https://codereview.chromium.org/2346743003/diff/60001/src/code-stubs.cc#newco... src/code-stubs.cc:5204: if (kind() == Code::KEYED_LOAD_IC) { On 2016/09/23 11:16:36, Toon Verwaest wrote: > Shouldn't this by now just be DCHECK_EQ(Code::KEYED_LOAD_IC, kind()) ? The LoadConstantStub still has LOAD_IC kind. Maybe we should port it finally. https://codereview.chromium.org/2346743003/diff/60001/src/code-stubs.cc#newco... src/code-stubs.cc:5208: DCHECK(kind() != Code::STORE_IC && kind() != Code::KEYED_STORE_IC); On 2016/09/23 11:16:36, Toon Verwaest wrote: > DCHECK_NE(Code::STORE_IC, kind()); > DCHECK_NE(...) Added another check instead: the kind is either LOAD_IC or KEYED_LOAD_IC.
The CQ bit was checked by ishell@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from verwaest@chromium.org Link to the patchset: https://codereview.chromium.org/2346743003/#ps80001 (title: "Addressing comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [ic] Remove unused xxxIC_MissFromStubFailure runtime functions. Namely: Runtime_LoadIC_MissFromStubFailure Runtime_StoreIC_MissFromStubFailure Runtime_KeyedStoreIC_MissFromStubFailure BUG=chromium:608675 ========== to ========== [ic] Remove unused xxxIC_MissFromStubFailure runtime functions. Namely: Runtime_LoadIC_MissFromStubFailure Runtime_StoreIC_MissFromStubFailure Runtime_KeyedStoreIC_MissFromStubFailure BUG=chromium:608675 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== [ic] Remove unused xxxIC_MissFromStubFailure runtime functions. Namely: Runtime_LoadIC_MissFromStubFailure Runtime_StoreIC_MissFromStubFailure Runtime_KeyedStoreIC_MissFromStubFailure BUG=chromium:608675 ========== to ========== [ic] Remove unused xxxIC_MissFromStubFailure runtime functions. Namely: Runtime_LoadIC_MissFromStubFailure Runtime_StoreIC_MissFromStubFailure Runtime_KeyedStoreIC_MissFromStubFailure BUG=chromium:608675 Committed: https://crrev.com/914519dda779322e378ae5e497b9e97cc3ffb71a Cr-Commit-Position: refs/heads/master@{#39675} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/914519dda779322e378ae5e497b9e97cc3ffb71a Cr-Commit-Position: refs/heads/master@{#39675} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
