Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Unified Diff: ui/gfx/render_text_harfbuzz.h

Issue 2346733002: Cleanup render text tests to use RenderTextTestApi. (Closed)
Patch Set: Remove redundant headers. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/render_text.h ('k') | ui/gfx/render_text_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/render_text_harfbuzz.h
diff --git a/ui/gfx/render_text_harfbuzz.h b/ui/gfx/render_text_harfbuzz.h
index 1d26c17fcb5e4f1fdab0603871ebd7e22c79cc02..43eae06c647cb469e9be2e60f95a2d656af95356 100644
--- a/ui/gfx/render_text_harfbuzz.h
+++ b/ui/gfx/render_text_harfbuzz.h
@@ -10,7 +10,6 @@
#include <memory>
-#include "base/gtest_prod_util.h"
#include "base/macros.h"
#include "base/memory/scoped_vector.h"
#include "third_party/harfbuzz-ng/src/hb.h"
@@ -178,30 +177,7 @@ class GFX_EXPORT RenderTextHarfBuzz : public RenderText {
private:
friend class test::RenderTextTestApi;
-
- FRIEND_TEST_ALL_PREFIXES(RenderTextHarfBuzzTest,
- Multiline_HorizontalAlignment);
- FRIEND_TEST_ALL_PREFIXES(RenderTextHarfBuzzTest, Multiline_NormalWidth);
- FRIEND_TEST_ALL_PREFIXES(RenderTextHarfBuzzTest, Multiline_WordWrapBehavior);
- FRIEND_TEST_ALL_PREFIXES(RenderTextHarfBuzzTest, HarfBuzz_RunDirection);
- FRIEND_TEST_ALL_PREFIXES(RenderTextHarfBuzzTest,
- HarfBuzz_HorizontalPositions);
- FRIEND_TEST_ALL_PREFIXES(RenderTextHarfBuzzTest,
- HarfBuzz_BreakRunsByUnicodeBlocks);
- FRIEND_TEST_ALL_PREFIXES(RenderTextHarfBuzzTest, HarfBuzz_BreakRunsByEmoji);
- FRIEND_TEST_ALL_PREFIXES(RenderTextHarfBuzzTest, HarfBuzz_BreakRunsByAscii);
- FRIEND_TEST_ALL_PREFIXES(RenderTextHarfBuzzTest,
- HarfBuzz_SubglyphGraphemeCases);
- FRIEND_TEST_ALL_PREFIXES(RenderTextHarfBuzzTest,
- HarfBuzz_SubglyphGraphemePartition);
- FRIEND_TEST_ALL_PREFIXES(RenderTextHarfBuzzTest, HarfBuzz_NonExistentFont);
- FRIEND_TEST_ALL_PREFIXES(RenderTextHarfBuzzTest, HarfBuzz_UniscribeFallback);
- FRIEND_TEST_ALL_PREFIXES(RenderTextHarfBuzzTest, HarfBuzz_UnicodeFallback);
- FRIEND_TEST_ALL_PREFIXES(RenderTextHarfBuzzTest,
- Multiline_LineBreakerBehavior);
- FRIEND_TEST_ALL_PREFIXES(RenderTextHarfBuzzTest,
- Multiline_SurrogatePairsOrCombiningChars);
- FRIEND_TEST_ALL_PREFIXES(RenderTextHarfBuzzTest, Multiline_ZeroWidthChars);
+ friend class RenderTextHarfBuzzTest;
// Specify the width of a glyph for test. The width of glyphs is very
// platform-dependent and environment-dependent. Otherwise multiline test
« no previous file with comments | « ui/gfx/render_text.h ('k') | ui/gfx/render_text_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698