Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: ui/gfx/render_text_harfbuzz.h

Issue 2346733002: Cleanup render text tests to use RenderTextTestApi. (Closed)
Patch Set: Fix compile. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/render_text_harfbuzz.h
diff --git a/ui/gfx/render_text_harfbuzz.h b/ui/gfx/render_text_harfbuzz.h
index 1d26c17fcb5e4f1fdab0603871ebd7e22c79cc02..522696112850dea456a70dcdd2ba09fdcaf28966 100644
--- a/ui/gfx/render_text_harfbuzz.h
+++ b/ui/gfx/render_text_harfbuzz.h
@@ -178,30 +178,7 @@ class GFX_EXPORT RenderTextHarfBuzz : public RenderText {
private:
friend class test::RenderTextTestApi;
-
- FRIEND_TEST_ALL_PREFIXES(RenderTextHarfBuzzTest,
- Multiline_HorizontalAlignment);
- FRIEND_TEST_ALL_PREFIXES(RenderTextHarfBuzzTest, Multiline_NormalWidth);
- FRIEND_TEST_ALL_PREFIXES(RenderTextHarfBuzzTest, Multiline_WordWrapBehavior);
- FRIEND_TEST_ALL_PREFIXES(RenderTextHarfBuzzTest, HarfBuzz_RunDirection);
- FRIEND_TEST_ALL_PREFIXES(RenderTextHarfBuzzTest,
- HarfBuzz_HorizontalPositions);
- FRIEND_TEST_ALL_PREFIXES(RenderTextHarfBuzzTest,
- HarfBuzz_BreakRunsByUnicodeBlocks);
- FRIEND_TEST_ALL_PREFIXES(RenderTextHarfBuzzTest, HarfBuzz_BreakRunsByEmoji);
- FRIEND_TEST_ALL_PREFIXES(RenderTextHarfBuzzTest, HarfBuzz_BreakRunsByAscii);
- FRIEND_TEST_ALL_PREFIXES(RenderTextHarfBuzzTest,
- HarfBuzz_SubglyphGraphemeCases);
- FRIEND_TEST_ALL_PREFIXES(RenderTextHarfBuzzTest,
- HarfBuzz_SubglyphGraphemePartition);
- FRIEND_TEST_ALL_PREFIXES(RenderTextHarfBuzzTest, HarfBuzz_NonExistentFont);
- FRIEND_TEST_ALL_PREFIXES(RenderTextHarfBuzzTest, HarfBuzz_UniscribeFallback);
- FRIEND_TEST_ALL_PREFIXES(RenderTextHarfBuzzTest, HarfBuzz_UnicodeFallback);
- FRIEND_TEST_ALL_PREFIXES(RenderTextHarfBuzzTest,
- Multiline_LineBreakerBehavior);
- FRIEND_TEST_ALL_PREFIXES(RenderTextHarfBuzzTest,
- Multiline_SurrogatePairsOrCombiningChars);
- FRIEND_TEST_ALL_PREFIXES(RenderTextHarfBuzzTest, Multiline_ZeroWidthChars);
+ friend class RenderTextHarfBuzzTest;
// Specify the width of a glyph for test. The width of glyphs is very
// platform-dependent and environment-dependent. Otherwise multiline test

Powered by Google App Engine
This is Rietveld 408576698