Cleanup render text tests to use RenderTextTestApi.

Cleanup render text tests to use RenderTextTestApi.

Currently, the RenderText classes provide access to their private/protected
members for tests using FRIEND_TEST_ALL_PREFIXES. This CL removes the need for
these macros by adding helpers to RenderTextTestApi and the test fixture
classes- RenderTextHarfBuzzTest and RenderTextMacTest.

BUG=none

Committed: https://crrev.com/77b028cf7da97d66d54e364b33b7274de69625c4
Cr-Commit-Position: refs/heads/master@{#419083}

[karandeepb, 2016-09-15 02:31:09]

The CQ bit was checked by karandeepb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 02:31:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 02:46:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 02:46:43]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[karandeepb, 2016-09-15 03:30:30]

The CQ bit was checked by karandeepb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 03:30:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[karandeepb, 2016-09-15 03:39:33]

Description was changed from

==========
Render Text Test
==========

to

==========
Cleanup render text tests to use RenderTextTestApi.

Currently, the RenderText classes provide access to their private/protected
members for tests using FRIEND_TEST_ALL_PREFIXES. This CL removes the need for
these macros by adding helpers to RenderTextTestApi and the test fixture
classes- RenderTextHarfBuzzTest and RenderTextMacTest.

BUG=none
==========

[commit-bot: I haz the power, 2016-09-15 04:17:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 04:17:26]

Dry run: This issue passed the CQ dry run.

[karandeepb, 2016-09-15 04:39:36]

karandeepb@chromium.org changed reviewers:
+ msw@chromium.org

[karandeepb, 2016-09-15 04:39:37]

PTAL msw@. You had recommended doing this in http://crrev.com/2251893004.

[msw, 2016-09-15 18:19:37]

Very nice! lgtm

https://codereview.chromium.org/2346733002/diff/20001/ui/gfx/render_text.h
File ui/gfx/render_text.h (right):

https://codereview.chromium.org/2346733002/diff/20001/ui/gfx/render_text.h#ne...
ui/gfx/render_text.h:18: #include "base/gtest_prod_util.h"
nit: remove this now?

https://codereview.chromium.org/2346733002/diff/20001/ui/gfx/render_text_harf...
File ui/gfx/render_text_harfbuzz.h (right):

https://codereview.chromium.org/2346733002/diff/20001/ui/gfx/render_text_harf...
ui/gfx/render_text_harfbuzz.h:13: #include "base/gtest_prod_util.h"
ditto nit: remove?

https://codereview.chromium.org/2346733002/diff/20001/ui/gfx/render_text_mac.h
File ui/gfx/render_text_mac.h (right):

https://codereview.chromium.org/2346733002/diff/20001/ui/gfx/render_text_mac....
ui/gfx/render_text_mac.h:15: #include "base/gtest_prod_util.h"
ditto nit: remove?

[karandeepb, 2016-09-16 01:08:56]

https://codereview.chromium.org/2346733002/diff/20001/ui/gfx/render_text.h
File ui/gfx/render_text.h (right):

https://codereview.chromium.org/2346733002/diff/20001/ui/gfx/render_text.h#ne...
ui/gfx/render_text.h:18: #include "base/gtest_prod_util.h"
On 2016/09/15 18:19:37, msw wrote:
> nit: remove this now?

Done.

https://codereview.chromium.org/2346733002/diff/20001/ui/gfx/render_text_harf...
File ui/gfx/render_text_harfbuzz.h (right):

https://codereview.chromium.org/2346733002/diff/20001/ui/gfx/render_text_harf...
ui/gfx/render_text_harfbuzz.h:13: #include "base/gtest_prod_util.h"
On 2016/09/15 18:19:37, msw wrote:
> ditto nit: remove?

Done.

https://codereview.chromium.org/2346733002/diff/20001/ui/gfx/render_text_mac.h
File ui/gfx/render_text_mac.h (right):

https://codereview.chromium.org/2346733002/diff/20001/ui/gfx/render_text_mac....
ui/gfx/render_text_mac.h:15: #include "base/gtest_prod_util.h"
On 2016/09/15 18:19:37, msw wrote:
> ditto nit: remove?

Done.

[karandeepb, 2016-09-16 01:09:19]

The CQ bit was checked by karandeepb@chromium.org

[karandeepb, 2016-09-16 01:09:20]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2346733002/#ps40001
(title: "Remove redundant headers.")

[commit-bot: I haz the power, 2016-09-16 01:10:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 02:53:40]

Description was changed from

==========
Cleanup render text tests to use RenderTextTestApi.

Currently, the RenderText classes provide access to their private/protected
members for tests using FRIEND_TEST_ALL_PREFIXES. This CL removes the need for
these macros by adding helpers to RenderTextTestApi and the test fixture
classes- RenderTextHarfBuzzTest and RenderTextMacTest.

BUG=none
==========

to

==========
Cleanup render text tests to use RenderTextTestApi.

Currently, the RenderText classes provide access to their private/protected
members for tests using FRIEND_TEST_ALL_PREFIXES. This CL removes the need for
these macros by adding helpers to RenderTextTestApi and the test fixture
classes- RenderTextHarfBuzzTest and RenderTextMacTest.

BUG=none
==========

[commit-bot: I haz the power, 2016-09-16 02:53:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-16 02:57:10]

Description was changed from

==========
Cleanup render text tests to use RenderTextTestApi.

Currently, the RenderText classes provide access to their private/protected
members for tests using FRIEND_TEST_ALL_PREFIXES. This CL removes the need for
these macros by adding helpers to RenderTextTestApi and the test fixture
classes- RenderTextHarfBuzzTest and RenderTextMacTest.

BUG=none
==========

to

==========
Cleanup render text tests to use RenderTextTestApi.

Currently, the RenderText classes provide access to their private/protected
members for tests using FRIEND_TEST_ALL_PREFIXES. This CL removes the need for
these macros by adding helpers to RenderTextTestApi and the test fixture
classes- RenderTextHarfBuzzTest and RenderTextMacTest.

BUG=none

Committed: https://crrev.com/77b028cf7da97d66d54e364b33b7274de69625c4
Cr-Commit-Position: refs/heads/master@{#419083}
==========

[commit-bot: I haz the power, 2016-09-16 02:57:12]

Patchset 3 (id:??) landed as
https://crrev.com/77b028cf7da97d66d54e364b33b7274de69625c4
Cr-Commit-Position: refs/heads/master@{#419083}