Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2346703002: [ios] Declare missing i variable in plugin_placeholder.js. (Closed)

Created:
4 years, 3 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 3 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Declare missing i variable in plugin_placeholder.js. BUG=487804 Committed: https://crrev.com/5c1a81e6a38635bb088f6e26f80b1242d1517ff1 Cr-Commit-Position: refs/heads/master@{#419246}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ios/web/web_state/js/resources/plugin_placeholder.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Eugene But (OOO till 7-30)
4 years, 3 months ago (2016-09-15 00:34:27 UTC) #2
Eugene But (OOO till 7-30)
Kurt?
4 years, 3 months ago (2016-09-16 17:58:48 UTC) #4
kkhorimoto
lgtm
4 years, 3 months ago (2016-09-16 18:24:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2346703002/1
4 years, 3 months ago (2016-09-16 18:25:35 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 19:22:22 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 19:25:47 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c1a81e6a38635bb088f6e26f80b1242d1517ff1
Cr-Commit-Position: refs/heads/master@{#419246}

Powered by Google App Engine
This is Rietveld 408576698