Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: chrome/test/chromedriver/session.h

Issue 23467010: [chromedriver] Logging tweaks and fixes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/session.h
diff --git a/chrome/test/chromedriver/session.h b/chrome/test/chromedriver/session.h
index a93c10a123d18463cff05fbb047adbd6d9971b3e..1e643cda4fbacd88078222c199d27c8908694050 100644
--- a/chrome/test/chromedriver/session.h
+++ b/chrome/test/chromedriver/session.h
@@ -48,6 +48,7 @@ struct Session {
void SwitchToSubFrame(const std::string& frame_id,
const std::string& chromedriver_frame_id);
std::string GetCurrentFrameId() const;
+ std::vector<WebDriverLog*> GetAllLogs() const;
const std::string id;
bool quit;
@@ -68,11 +69,13 @@ struct Session {
scoped_ptr<Geoposition> overridden_geoposition;
// Logs that populate from DevTools events.
ScopedVector<WebDriverLog> devtools_logs;
+ scoped_ptr<WebDriverLog> driver_log;
base::ScopedTempDir temp_dir;
- const scoped_ptr<base::DictionaryValue> capabilities;
-
- private:
- scoped_ptr<base::DictionaryValue> CreateCapabilities();
+ scoped_ptr<base::DictionaryValue> capabilities;
};
+Session* GetThreadLocalSession();
+
+void SetThreadLocalSession(scoped_ptr<Session> session);
+
#endif // CHROME_TEST_CHROMEDRIVER_SESSION_H_

Powered by Google App Engine
This is Rietveld 408576698