chrome/test/chromedriver/commands_unittest.cc - Issue 23467010: [chromedriver] Logging tweaks and fixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/commands_unittest.cc

Issue 23467010: [chromedriver] Logging tweaks and fixes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/chromedriver/commands.cc ('K') | « chrome/test/chromedriver/commands.cc ('k') | chrome/test/chromedriver/logging.cc » ('j') | chrome/test/chromedriver/server/http_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/commands_unittest.cc

diff --git a/chrome/test/chromedriver/commands_unittest.cc b/chrome/test/chromedriver/commands_unittest.cc

index e377d2921813e96984c66dfdb749a429170379e8..44571863054bbd1a38e1ca25808019295033843a 100644

--- a/chrome/test/chromedriver/commands_unittest.cc

+++ b/chrome/test/chromedriver/commands_unittest.cc

@@ -138,6 +138,7 @@ TEST(CommandsTest, ExecuteSessionCommand) {

base::RunLoop run_loop;

ExecuteSessionCommand(

&map,

+ "cmd",

cmd,

false,

params,

@@ -176,6 +177,7 @@ TEST(CommandsTest, ExecuteSessionCommandOnNoSuchSession) {

SessionThreadMap map;

base::DictionaryValue params;

ExecuteSessionCommand(&map,

+ "cmd",

base::Bind(&ShouldNotBeCalled),

false,

params,

@@ -187,6 +189,7 @@ TEST(CommandsTest, ExecuteSessionCommandOnNoSuchSessionWhenItExpectsOk) {

SessionThreadMap map;

base::DictionaryValue params;

ExecuteSessionCommand(&map,

+ "cmd",

base::Bind(&ShouldNotBeCalled),

true,

params,

@@ -217,6 +220,7 @@ TEST(CommandsTest, ExecuteSessionCommandOnJustDeletedSession) {

base::MessageLoop loop;

base::RunLoop run_loop;

ExecuteSessionCommand(&map,

+ "cmd",

base::Bind(&ShouldNotBeCalled),

false,

base::DictionaryValue(),

« chrome/test/chromedriver/commands.cc ('K') | « chrome/test/chromedriver/commands.cc ('k') | chrome/test/chromedriver/logging.cc » ('j') | chrome/test/chromedriver/server/http_handler.cc » ('J')