Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2098)

Unified Diff: chrome/test/chromedriver/logging_unittest.cc

Issue 23467010: [chromedriver] Logging tweaks and fixes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/logging.cc ('k') | chrome/test/chromedriver/server/http_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/logging_unittest.cc
diff --git a/chrome/test/chromedriver/logging_unittest.cc b/chrome/test/chromedriver/logging_unittest.cc
index f3de397d8cf8fcedd50d6d4f045bc03faf772041..67555548306bc11c20121dcdc50f9ef43d70ed40 100644
--- a/chrome/test/chromedriver/logging_unittest.cc
+++ b/chrome/test/chromedriver/logging_unittest.cc
@@ -103,14 +103,12 @@ TEST(Logging, CreatePerformanceLog) {
ScopedVector<DevToolsEventListener> listeners;
ScopedVector<WebDriverLog> logs;
- scoped_ptr<WebDriverLog> driver_log;
- Status status = CreateLogs(capabilities, &logs, &driver_log, &listeners);
+ Status status = CreateLogs(capabilities, &logs, &listeners);
ASSERT_TRUE(status.IsOk());
ASSERT_EQ(2u, logs.size());
ASSERT_EQ(2u, listeners.size());
ASSERT_EQ("performance", logs[0]->type());
ASSERT_EQ("browser", logs[1]->type());
- ASSERT_EQ("driver", driver_log->type());
}
TEST(Logging, IgnoreUnknownLogType) {
@@ -119,8 +117,7 @@ TEST(Logging, IgnoreUnknownLogType) {
ScopedVector<DevToolsEventListener> listeners;
ScopedVector<WebDriverLog> logs;
- scoped_ptr<WebDriverLog> driver_log;
- Status status = CreateLogs(capabilities, &logs, &driver_log, &listeners);
+ Status status = CreateLogs(capabilities, &logs, &listeners);
EXPECT_TRUE(status.IsOk());
ASSERT_EQ(1u, logs.size());
ASSERT_EQ(0u, listeners.size());
@@ -132,11 +129,8 @@ TEST(Logging, DefaultLogs) {
ScopedVector<DevToolsEventListener> listeners;
ScopedVector<WebDriverLog> logs;
- scoped_ptr<WebDriverLog> driver_log;
- Status status = CreateLogs(capabilities, &logs, &driver_log, &listeners);
+ Status status = CreateLogs(capabilities, &logs, &listeners);
EXPECT_TRUE(status.IsOk());
ASSERT_EQ(1u, logs.size());
ASSERT_EQ(0u, listeners.size());
- ASSERT_EQ("driver", driver_log->type());
- ASSERT_EQ(Log::kWarning, driver_log->min_level());
}
« no previous file with comments | « chrome/test/chromedriver/logging.cc ('k') | chrome/test/chromedriver/server/http_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698