Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Side by Side Diff: chrome/test/chromedriver/logging_unittest.cc

Issue 23467010: [chromedriver] Logging tweaks and fixes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/test/chromedriver/logging.cc ('k') | chrome/test/chromedriver/server/http_handler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/values.h" 5 #include "base/values.h"
6 #include "chrome/test/chromedriver/capabilities.h" 6 #include "chrome/test/chromedriver/capabilities.h"
7 #include "chrome/test/chromedriver/chrome/devtools_event_listener.h" 7 #include "chrome/test/chromedriver/chrome/devtools_event_listener.h"
8 #include "chrome/test/chromedriver/chrome/log.h" 8 #include "chrome/test/chromedriver/chrome/log.h"
9 #include "chrome/test/chromedriver/chrome/status.h" 9 #include "chrome/test/chromedriver/chrome/status.h"
10 #include "chrome/test/chromedriver/logging.h" 10 #include "chrome/test/chromedriver/logging.h"
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 ValidateLogEntry(entries.get(), 1, "DEBUG", "debug message"); 96 ValidateLogEntry(entries.get(), 1, "DEBUG", "debug message");
97 } 97 }
98 98
99 TEST(Logging, CreatePerformanceLog) { 99 TEST(Logging, CreatePerformanceLog) {
100 Capabilities capabilities; 100 Capabilities capabilities;
101 capabilities.logging_prefs["performance"] = Log::kInfo; 101 capabilities.logging_prefs["performance"] = Log::kInfo;
102 capabilities.logging_prefs["browser"] = Log::kInfo; 102 capabilities.logging_prefs["browser"] = Log::kInfo;
103 103
104 ScopedVector<DevToolsEventListener> listeners; 104 ScopedVector<DevToolsEventListener> listeners;
105 ScopedVector<WebDriverLog> logs; 105 ScopedVector<WebDriverLog> logs;
106 scoped_ptr<WebDriverLog> driver_log; 106 Status status = CreateLogs(capabilities, &logs, &listeners);
107 Status status = CreateLogs(capabilities, &logs, &driver_log, &listeners);
108 ASSERT_TRUE(status.IsOk()); 107 ASSERT_TRUE(status.IsOk());
109 ASSERT_EQ(2u, logs.size()); 108 ASSERT_EQ(2u, logs.size());
110 ASSERT_EQ(2u, listeners.size()); 109 ASSERT_EQ(2u, listeners.size());
111 ASSERT_EQ("performance", logs[0]->type()); 110 ASSERT_EQ("performance", logs[0]->type());
112 ASSERT_EQ("browser", logs[1]->type()); 111 ASSERT_EQ("browser", logs[1]->type());
113 ASSERT_EQ("driver", driver_log->type());
114 } 112 }
115 113
116 TEST(Logging, IgnoreUnknownLogType) { 114 TEST(Logging, IgnoreUnknownLogType) {
117 Capabilities capabilities; 115 Capabilities capabilities;
118 capabilities.logging_prefs["gaga"] = Log::kInfo; 116 capabilities.logging_prefs["gaga"] = Log::kInfo;
119 117
120 ScopedVector<DevToolsEventListener> listeners; 118 ScopedVector<DevToolsEventListener> listeners;
121 ScopedVector<WebDriverLog> logs; 119 ScopedVector<WebDriverLog> logs;
122 scoped_ptr<WebDriverLog> driver_log; 120 Status status = CreateLogs(capabilities, &logs, &listeners);
123 Status status = CreateLogs(capabilities, &logs, &driver_log, &listeners);
124 EXPECT_TRUE(status.IsOk()); 121 EXPECT_TRUE(status.IsOk());
125 ASSERT_EQ(1u, logs.size()); 122 ASSERT_EQ(1u, logs.size());
126 ASSERT_EQ(0u, listeners.size()); 123 ASSERT_EQ(0u, listeners.size());
127 ASSERT_EQ("browser", logs[0]->type()); 124 ASSERT_EQ("browser", logs[0]->type());
128 } 125 }
129 126
130 TEST(Logging, DefaultLogs) { 127 TEST(Logging, DefaultLogs) {
131 Capabilities capabilities; 128 Capabilities capabilities;
132 129
133 ScopedVector<DevToolsEventListener> listeners; 130 ScopedVector<DevToolsEventListener> listeners;
134 ScopedVector<WebDriverLog> logs; 131 ScopedVector<WebDriverLog> logs;
135 scoped_ptr<WebDriverLog> driver_log; 132 Status status = CreateLogs(capabilities, &logs, &listeners);
136 Status status = CreateLogs(capabilities, &logs, &driver_log, &listeners);
137 EXPECT_TRUE(status.IsOk()); 133 EXPECT_TRUE(status.IsOk());
138 ASSERT_EQ(1u, logs.size()); 134 ASSERT_EQ(1u, logs.size());
139 ASSERT_EQ(0u, listeners.size()); 135 ASSERT_EQ(0u, listeners.size());
140 ASSERT_EQ("driver", driver_log->type());
141 ASSERT_EQ(Log::kWarning, driver_log->min_level());
142 } 136 }
OLDNEW
« no previous file with comments | « chrome/test/chromedriver/logging.cc ('k') | chrome/test/chromedriver/server/http_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698