Issue 23467008: Whitelist new ADT id for developerPrivate api.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23467008: Whitelist new ADT id for developerPrivate api. (Closed)

Created:
7 years, 3 months ago by Gaurav

Modified:
7 years, 3 months ago

Reviewers:
asargent_no_longer_on_chrome

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, dvh

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Whitelist new ADT id for developerPrivate api. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222144

Patch Set 3 : . #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/common/extensions/api/_permission_features.json	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

asargent_no_longer_on_chrome

lgtm https://codereview.chromium.org/23467008/diff/1/chrome/common/extensions/api/_permission_features.json File chrome/common/extensions/api/_permission_features.json (right): https://codereview.chromium.org/23467008/diff/1/chrome/common/extensions/api/_permission_features.json#newcode164 chrome/common/extensions/api/_permission_features.json:164: "ohmmkhmmmpcnpikjeljgnaoabkaalbgc", // Apps developer tool published. nit: might ...

7 years, 3 months ago (2013-09-05 21:10:15 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/23467008/11001

7 years, 3 months ago (2013-09-09 21:24:01 UTC) #3

Message was sent while issue was closed.

Change committed as 222144

Expand Messages | Collapse Messages

Issue 23467008: Whitelist new ADT id for developerPrivate api. (Closed)

Description

Patch Set 1 #

Patch Set 2 : comments. #

Patch Set 3 : . #

Messages