Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Unified Diff: build/android/pylib/base/base_test_runner.py

Issue 23467004: [android] Update FlagChanger to work with additional apks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: addressed comments Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/pylib/constants.py » ('j') | build/android/pylib/flag_changer.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/base/base_test_runner.py
diff --git a/build/android/pylib/base/base_test_runner.py b/build/android/pylib/base/base_test_runner.py
index bd8fefeea72f3e40c62ac4b13609ed43e9bfe583..154ea66841dc428b8efe069eab7a27bea1f61882 100644
--- a/build/android/pylib/base/base_test_runner.py
+++ b/build/android/pylib/base/base_test_runner.py
@@ -15,7 +15,6 @@ from pylib import android_commands
from pylib import constants
from pylib import ports
from pylib.chrome_test_server_spawner import SpawningServer
-from pylib.flag_changer import FlagChanger
from pylib.forwarder import Forwarder
from pylib.valgrind_tools import CreateTool
# TODO(frankf): Move this to pylib/utils
@@ -45,8 +44,6 @@ class BaseTestRunner(object):
self._forwarder_device_port = 8000
self.forwarder_base_url = ('http://localhost:%d' %
self._forwarder_device_port)
- self.flags = FlagChanger(self.adb)
- self.flags.AddFlags(['--disable-fre'])
self._spawning_server = None
# We will allocate port for test server spawner when calling method
# LaunchChromeTestServerSpawner and allocate port for test server when
@@ -166,7 +163,6 @@ class BaseTestRunner(object):
self._http_server.ShutdownHttpServer()
if self._spawning_server:
self._spawning_server.Stop()
- self.flags.Restore()
def CleanupSpawningServerState(self):
"""Tells the spawning server to clean up any state.
« no previous file with comments | « no previous file | build/android/pylib/constants.py » ('j') | build/android/pylib/flag_changer.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698