Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Side by Side Diff: media/cast/framer/cast_message_builder.cc

Issue 23467003: Added framer to cast. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rtcp
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "media/cast/framer/cast_message_builder.h"
6
7 namespace media {
8 namespace cast {
9
10 static const uint16 kCompleteFrameLost = 0xffff;
11
12 CastMessageBuilder::CastMessageBuilder(
13 RtpPayloadFeedback* incoming_payload_feedback,
14 FrameIdMap* frame_id_map,
15 uint32 media_ssrc,
16 bool decoder_faster_than_max_frame_rate,
17 int max_unacked_frames)
18 : cast_feedback_(incoming_payload_feedback),
19 frame_id_map_(frame_id_map),
20 media_ssrc_(media_ssrc),
21 decoder_faster_than_max_frame_rate_(decoder_faster_than_max_frame_rate),
22 max_unacked_frames_(max_unacked_frames),
23 cast_msg_(media_ssrc),
24 waiting_for_key_frame_(true),
25 slowing_down_ack_(false),
26 acked_last_frame_(true),
27 last_acked_frame_id_(kStartFrameId),
28 default_tick_clock_(new base::DefaultTickClock()),
29 clock_(default_tick_clock_.get()) {
30 cast_msg_.ack_frame_id_ = kStartFrameId;
31 }
32
33 CastMessageBuilder::~CastMessageBuilder() {}
34
35 void CastMessageBuilder::CompleteFrameReceived(uint8 frame_id,
36 bool is_key_frame) {
37 if (last_update_time_.is_null()) {
38 // Our first update.
39 last_update_time_ = clock_->NowTicks();
40 }
41 if (waiting_for_key_frame_) {
42 if (!is_key_frame) {
43 // Ignore that we have received this complete frame since we are
44 // waiting on a key frame.
45 return;
46 }
47 waiting_for_key_frame_ = false;
48 cast_msg_.missing_frames_and_packets_.clear();
49 cast_msg_.ack_frame_id_ = frame_id;
50 last_update_time_ = clock_->NowTicks();
51 // We might have other complete frames waiting after we receive the last
52 // packet in the key-frame.
53 UpdateAckMessage();
54 } else {
55 if (!UpdateAckMessage()) return;
Alpha Left Google 2013/08/28 00:27:31 nit: This looks strange, return can just move to n
pwestin 2013/08/28 16:40:44 Done.
56
57 BuildPacketList();
58 }
59 // Send cast message.
60 cast_feedback_->CastFeedback(cast_msg_);
61 }
62
63 bool CastMessageBuilder::UpdateAckMessage() {
64 if (!decoder_faster_than_max_frame_rate_) {
65 int complete_frame_count = frame_id_map_->NumberOfCompleteFrames();
66 if (complete_frame_count > max_unacked_frames_) {
67 // We have too many frames pending in our framer; slow down ACK.
68 slowing_down_ack_ = true;
69 } else if (complete_frame_count <= 1) {
70 // We are down to one or less frames in our framer; ACK normally.
71 slowing_down_ack_ = false;
72 }
73 }
74 if (slowing_down_ack_) {
75 // We are slowing down acknowledgment by acknowledging every other frame.
76 if (acked_last_frame_) {
77 acked_last_frame_ = false;
78 } else {
79 acked_last_frame_ = true;
80 last_acked_frame_id_++;
81 // Note: frame skipping and slowdown ACK is not supported at the same
82 // time; and it's not needed since we can skip frames to catch up.
83 }
84 } else {
85 uint8 frame_id = frame_id_map_->LastContinuousFrame();
86
87 // Is it a new frame?
88 if (last_acked_frame_id_ == frame_id) return false;
Alpha Left Google 2013/08/28 00:27:31 nit: return false can move to next line or one spa
pwestin 2013/08/28 16:40:44 Done.
89
90 last_acked_frame_id_ = frame_id;
91 acked_last_frame_ = true;
92 }
93 cast_msg_.ack_frame_id_ = last_acked_frame_id_;
94 cast_msg_.missing_frames_and_packets_.clear();
95 last_update_time_ = clock_->NowTicks();
96 return true;
97 }
98
99 bool CastMessageBuilder::TimeToSendNextCastMessage(
100 base::TimeTicks* time_to_send) {
101 // We haven't received any packets.
102 if (last_update_time_.is_null() && frame_id_map_->Empty()) return false;
Alpha Left Google 2013/08/28 00:27:31 nit: return can go to next line or 1 space.
pwestin 2013/08/28 16:40:44 Done.
103
104 *time_to_send = last_update_time_ +
105 base::TimeDelta::FromMilliseconds(kCastMessageUpdateIntervalMs);
106 return true;
107 }
108
109 void CastMessageBuilder::UpdateCastMessage() {
110 RtcpCastMessage message(media_ssrc_);
111 if (!UpdateCastMessageInternal(&message)) return;
Alpha Left Google 2013/08/28 00:27:31 nit: return can go to next line or 1 space.
pwestin 2013/08/28 16:40:44 Done.
112 // Send cast message.
113 cast_feedback_->CastFeedback(message);
114 }
115
116 void CastMessageBuilder::Reset() {
117 waiting_for_key_frame_ = true;
118 cast_msg_.ack_frame_id_ = kStartFrameId;
119 cast_msg_.missing_frames_and_packets_.clear();
120 time_last_nacked_map_.clear();
121 }
122
123 bool CastMessageBuilder::UpdateCastMessageInternal(RtcpCastMessage* message) {
124 if (last_update_time_.is_null()) {
125 if (!frame_id_map_->Empty()) {
126 // We have received packets.
127 last_update_time_ = clock_->NowTicks();
128 }
129 return false;
130 }
131 // Is it time to update the cast message?
132 base::TimeTicks now = clock_->NowTicks();
133 if (now - last_update_time_ <
134 base::TimeDelta::FromMilliseconds(kCastMessageUpdateIntervalMs)) {
135 return false;
136 }
137 last_update_time_ = now;
138
139 UpdateAckMessage(); // Needed to cover when a frame is skipped.
140 BuildPacketList();
141 *message = cast_msg_;
142 return true;
143 }
144
145 void CastMessageBuilder::BuildPacketList() {
146 base::TimeTicks now = clock_->NowTicks();
147
148 // Clear message NACK list.
149 cast_msg_.missing_frames_and_packets_.clear();
150
151 // Are we missing packets?
152 if (frame_id_map_->Empty()) return;
Alpha Left Google 2013/08/28 00:27:31 nit: return can go to next line or 1 space.
pwestin 2013/08/28 16:40:44 Done.
153
154 uint8 newest_frame_id = frame_id_map_->NewestFrameId();
155 uint8 next_expected_frame_id =
156 static_cast<uint8>(cast_msg_.ack_frame_id_ + 1);
157
158 // Iterate over all frames.
159 for (; !IsNewerFrameId(next_expected_frame_id, newest_frame_id);
160 ++next_expected_frame_id) {
161 std::map<uint8, base::TimeTicks>::iterator it =
Alpha Left Google 2013/08/28 00:27:31 Use typdef'ed type here for readability.
pwestin 2013/08/28 16:40:44 Done.
162 time_last_nacked_map_.find(next_expected_frame_id);
163 if (it != time_last_nacked_map_.end()) {
164 // We have sent a NACK in this frame before, make sure enough time have
165 // passed.
166 if (now - it->second <
167 base::TimeDelta::FromMilliseconds(kNackRepeatIntervalMs)) {
168 continue;
169 }
170 }
171
172 std::set<uint16> missing;
Alpha Left Google 2013/08/28 00:27:31 This should use a typedef'ed type like PacketIdSet
pwestin 2013/08/28 16:40:44 Done.
173 if (frame_id_map_->FrameExists(next_expected_frame_id)) {
174 bool last_frame = (newest_frame_id == next_expected_frame_id);
175 frame_id_map_->GetMissingPackets(next_expected_frame_id, last_frame,
176 &missing);
177 if (!missing.empty()) {
178 time_last_nacked_map_[next_expected_frame_id] = now;
179 cast_msg_.missing_frames_and_packets_.insert(
180 std::pair<uint8, std::set<uint16> >(
Alpha Left Google 2013/08/28 00:27:31 Use std::make_pair() instead so types are inferred
pwestin 2013/08/28 16:40:44 Done.
181 next_expected_frame_id, missing));
182 }
183 } else {
184 time_last_nacked_map_[next_expected_frame_id] = now;
185 missing.insert(kCompleteFrameLost);
186 cast_msg_.missing_frames_and_packets_[next_expected_frame_id] = missing;
187 }
188 }
189 }
190
191 } // namespace cast
192 } // namespace media
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698