Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 2346673002: Fix for non-live RenderFramehosts incorrectly marked as live. (Closed)

Created:
4 years, 3 months ago by paulmeyer
Modified:
4 years, 3 months ago
Reviewers:
alexmos
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for non-live RenderFramehosts incorrectly marked as live. I noticed that FrameTreeNodes that contain inner WebContentses have RenderFrameHosts that are marked "live" (for the purposes of RenderFrameHost::IsRenderFrameHostLive()) even though they do not have any associated RenderFrames. This patch fixes that. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/7c9f142cbe4ed4563ed032fc8290318120141842 Cr-Commit-Position: refs/heads/master@{#419150}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/browser/frame_host/render_frame_host_manager.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
paulmeyer
4 years, 3 months ago (2016-09-15 00:12:52 UTC) #4
alexmos
LGTM, thanks for catching this! I wonder if it's easy or worthwhile to add coverage ...
4 years, 3 months ago (2016-09-15 21:27:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2346673002/1
4 years, 3 months ago (2016-09-16 12:48:43 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 12:53:23 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 12:55:32 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c9f142cbe4ed4563ed032fc8290318120141842
Cr-Commit-Position: refs/heads/master@{#419150}

Powered by Google App Engine
This is Rietveld 408576698