Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2346663003: Add ability to create and upload SVGs from a local dir (Closed)

Created:
4 years, 3 months ago by rmistry
Modified:
4 years, 3 months ago
Reviewers:
jcgregorio, borenet
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add ability to create and upload SVGs from a local dir BUG=skia:5757 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2346663003 Committed: https://skia.googlesource.com/skia/+/5caf398cacbfd48118a6e925f7145360cb1fb587

Patch Set 1 : Initial upload #

Patch Set 2 : Cleanup #

Patch Set 3 : Nit #

Patch Set 4 : Fix default #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M infra/bots/assets/svg/create.py View 1 2 3 1 chunk +11 lines, -2 lines 0 comments Download
M infra/bots/assets/svg/create_and_upload.py View 1 2 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
rmistry
4 years, 3 months ago (2016-09-15 15:24:49 UTC) #3
borenet
LGTM
4 years, 3 months ago (2016-09-15 16:08:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2346663003/60001
4 years, 3 months ago (2016-09-15 16:15:49 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 16:33:12 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/5caf398cacbfd48118a6e925f7145360cb1fb587

Powered by Google App Engine
This is Rietveld 408576698