Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: net/cert/internal/test_helpers.h

Issue 2346663002: Generalize rebase-errors.py so it works for other files. (Closed)
Patch Set: moar comment wording Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/internal/test_helpers.h
diff --git a/net/cert/internal/test_helpers.h b/net/cert/internal/test_helpers.h
index 83e823889498350ede5c8ba990d62735b0798d7e..0e4cd17a58d8bd4f259a1b9267738858bf23b7ae 100644
--- a/net/cert/internal/test_helpers.h
+++ b/net/cert/internal/test_helpers.h
@@ -76,10 +76,12 @@ template <size_t N>
return ReadTestDataFromPemFile(file_path_ascii, mappings, N);
}
-// Reads a test case from |file_name|. Test cases are comprised of a
-// certificate chain, trust anchor, a timestamp to validate at, and the
-// expected result of verification.
-void ReadVerifyCertChainTestFromFile(const std::string& file_name,
+// Reads a test case from |file_path_ascii| (which is relative to //src). Test
+// cases are comprised of a certificate chain, trust anchor, a timestamp to
+// validate at, and the expected result of verification.
+// Generally |file_path_ascii| will start with:
+// net/data/verify_certificate_chain_unittest/
+void ReadVerifyCertChainTestFromFile(const std::string& file_path_ascii,
ParsedCertificateList* chain,
scoped_refptr<TrustAnchor>* trust_anchor,
der::GeneralizedTime* time,
@@ -87,7 +89,7 @@ void ReadVerifyCertChainTestFromFile(const std::string& file_name,
std::string* expected_errors);
// Reads a data file relative to the src root directory.
-std::string ReadTestFileToString(const std::string& file_name);
+std::string ReadTestFileToString(const std::string& file_path_ascii);
} // namespace net
« no previous file with comments | « net/cert/internal/path_builder_verify_certificate_chain_unittest.cc ('k') | net/cert/internal/test_helpers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698