remoting/host/linux/unicode_to_keysym_unittest.cc - Issue 2346643003: [Remoting Host] Handle text event characters that are not presented on the keyboard

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/linux/unicode_to_keysym_unittest.cc

Issue 2346643003: [Remoting Host] Handle text event characters that are not presented on the keyboard (Closed)

Patch Set: Fix Flakiness Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/host/linux/unicode_to_keysym_unittest.cc

diff --git a/remoting/host/linux/unicode_to_keysym_unittest.cc b/remoting/host/linux/unicode_to_keysym_unittest.cc

index 57516479d2b68554590de65730481d9cd2b5305a..80a3cdb7c434b3fba2c17f6b0ee163dcf09240f2 100644

--- a/remoting/host/linux/unicode_to_keysym_unittest.cc

+++ b/remoting/host/linux/unicode_to_keysym_unittest.cc

@@ -37,8 +37,7 @@ TEST(GetKeySymsForUnicode, Map) {

};

for (size_t i = 0; i < arraysize(kTests); ++i) {

- std::vector<uint32_t> keysyms;

- GetKeySymsForUnicode(kTests[i].code_point, &keysyms);

+ std::vector<uint32_t> keysyms = GetKeySymsForUnicode(kTests[i].code_point);

std::vector<uint32_t> expected(

kTests[i].expected_keysyms,