[Remoting Host] Handle text event characters that are not presented on the keyboard

remoting/host/linux/x11_character_injector_unittest.cc

Index: remoting/host/linux/x11_character_injector_unittest.cc
diff --git a/remoting/host/linux/x11_character_injector_unittest.cc b/remoting/host/linux/x11_character_injector_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..ac1669459574e296a42a1a651352107d5cfe0c1a
--- /dev/null
+++ b/remoting/host/linux/x11_character_injector_unittest.cc
@@ -0,0 +1,322 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "remoting/host/linux/x11_character_injector.h"
+
+#include <stdarg.h>
+
+#include <map>
+
+#include "base/memory/ptr_util.h"
+#include "base/message_loop/message_loop.h"
+#include "base/run_loop.h"
+#include "base/threading/thread_task_runner_handle.h"
+#include "remoting/host/linux/x11_keyboard.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+
+const int kMappingExpireMs = 200;
+
+base::TimeDelta TimeDeltaMs(int ms) {
+  return base::TimeDelta::FromMilliseconds(ms);
+}
+
+}  // namespace
+
+namespace remoting {
+
+class FakeX11Keyboard : public X11Keyboard {
+ public:
+  struct KeyPressExpectation {
+    base::TimeDelta min_delay;  // To the last key press.
+    base::TimeDelta max_delay;
+    uint32_t keycode;
+  };
+
+  struct ChangeKeyMappingExpectation {
+    uint32_t keycode;
+    uint32_t code_point;
+  };
+
+  explicit FakeX11Keyboard(const std::vector<uint32_t>& available_keycodes);
+  ~FakeX11Keyboard() override;
+
+  std::vector<uint32_t> GetUnusedKeycodes() override;
+
+  void PressKey(uint32_t keycode, uint32_t modifiers) override;
+  bool FindKeycode(uint32_t code_point,
+                   uint32_t* keycode,
+                   uint32_t* modifiers) override;
+  bool ChangeKeyMapping(uint32_t keycode, uint32_t code_point) override;
+  void Flush() override;
+  void Sync() override;
+
+  void ExpectKeyPress(const std::vector<KeyPressExpectation>& sequence);
+  void ExpectChangeKeyMapping(
+      const std::vector<ChangeKeyMappingExpectation>& sequence);
+  void InjectorAboutToDestruct();
+
+  // Sets a callback to be called when the keypress expectation queue becomes
+  // empty.
+  void SetKeyPressFinishedCallback(const base::Closure& callback) {
+    keypress_finished_callback_ = callback;
+  }
+
+ private:
+  static const int kSyncDelayMs = 1;
+
+  std::map<uint32_t, uint32_t> keycode_mapping_;
+  std::queue<KeyPressExpectation> keypress_expectations_;
+  std::queue<ChangeKeyMappingExpectation> change_key_mapping_expectations_;
+  bool injector_about_to_destruct_ = false;
+  base::TimeTicks last_keypress_time_;
+  base::Closure keypress_finished_callback_;
+};
+
+FakeX11Keyboard::FakeX11Keyboard(
+    const std::vector<uint32_t>& available_keycodes) {
+  for (uint32_t keycode : available_keycodes) {
+    keycode_mapping_.insert({keycode, 0});
+  }
+}
+
+FakeX11Keyboard::~FakeX11Keyboard() {
+  DCHECK(keypress_expectations_.empty());
+  DCHECK(change_key_mapping_expectations_.empty());
+  for (const auto& pair : keycode_mapping_) {
+    EXPECT_EQ(0u, pair.second);
+  }
+}
+
+std::vector<uint32_t> FakeX11Keyboard::GetUnusedKeycodes() {
+  std::vector<uint32_t> keycodes;
+  for (const auto& pair : keycode_mapping_) {
+    if (!pair.second) {
+      keycodes.push_back(pair.first);
+    }
+  }
+  return keycodes;
+}
+
+void FakeX11Keyboard::PressKey(uint32_t keycode, uint32_t modifiers) {
+  ASSERT_FALSE(keypress_expectations_.empty());
+  KeyPressExpectation& expectation = keypress_expectations_.front();
+  ASSERT_EQ(expectation.keycode, keycode);
+  base::TimeTicks now = base::TimeTicks::Now();
+  base::TimeDelta delay = now - last_keypress_time_;
+  ASSERT_GE(delay, expectation.min_delay);
+  ASSERT_LE(delay, expectation.max_delay);
+  last_keypress_time_ = now;
+  keypress_expectations_.pop();
+  if (keypress_expectations_.empty() && keypress_finished_callback_) {
+    keypress_finished_callback_.Run();
+  }
+}
+
+bool FakeX11Keyboard::FindKeycode(uint32_t code_point,
+                                  uint32_t* keycode,
+                                  uint32_t* modifiers) {
+  auto position = std::find_if(keycode_mapping_.begin(), keycode_mapping_.end(),
+               [code_point](const std::pair<uint32_t, uint32_t>& pair) {
+    return pair.second == code_point;
+  });
+  if (position == keycode_mapping_.end()) {
+    return false;
+  }
+  *keycode = position->first;
+  *modifiers = 0;
+  return true;
+}
+
+bool FakeX11Keyboard::ChangeKeyMapping(uint32_t keycode, uint32_t code_point) {
+  if (injector_about_to_destruct_) {
+    EXPECT_EQ(0u, code_point);
+  } else {
+    EXPECT_FALSE(change_key_mapping_expectations_.empty())
+        << "Unexpected change key request. Key Code: " << keycode
+        << " Code Point: " << code_point;
+    ChangeKeyMappingExpectation& expectation =
+        change_key_mapping_expectations_.front();
+    EXPECT_EQ(expectation.keycode, keycode);
+    EXPECT_EQ(expectation.code_point, code_point);
+    change_key_mapping_expectations_.pop();
+  }
+
+  keycode_mapping_[keycode] = code_point;
+  return true;
+}
+
+void FakeX11Keyboard::Flush() {}
+
+void FakeX11Keyboard::Sync() {
+  usleep(kSyncDelayMs * 1000);
+}
+
+void FakeX11Keyboard::ExpectKeyPress(
+    const std::vector<KeyPressExpectation>& sequence) {
+  for (const auto& expectation : sequence) {
+    keypress_expectations_.push(expectation);
+  }
+}
+
+void FakeX11Keyboard::ExpectChangeKeyMapping(
+    const std::vector<ChangeKeyMappingExpectation>& sequence) {
+  for (const auto& expectation : sequence) {
+    change_key_mapping_expectations_.push(expectation);
+  }
+}
+
+void FakeX11Keyboard::InjectorAboutToDestruct() {
+  injector_about_to_destruct_ = true;
+}
+
+class X11CharacterInjectorTest : public testing::Test {
+ public:
+  void SetUp() override;
+  void TearDown() override;
+
+ protected:
+  void ResetRunLoop();
+  void FillUntilFull(bool immediately_run);
+
+  std::unique_ptr<X11CharacterInjector> injector_;
+  FakeX11Keyboard* keyboard_;  // Owned by |injector_|.
+
+  base::MessageLoop message_loop_;
+  std::unique_ptr<base::RunLoop> run_loop_;
+};
+
+void X11CharacterInjectorTest::SetUp() {
+  keyboard_ = new FakeX11Keyboard({55, 54, 53, 52, 51});
+  injector_.reset(new X11CharacterInjector(base::WrapUnique(keyboard_)));
+  ResetRunLoop();
+}
+
+void X11CharacterInjectorTest::TearDown() {
+  run_loop_->Run();
+  keyboard_->InjectorAboutToDestruct();
+  injector_.reset();
+}
+
+void X11CharacterInjectorTest::ResetRunLoop() {
+  run_loop_.reset(new base::RunLoop());
+  keyboard_->SetKeyPressFinishedCallback(run_loop_->QuitClosure());
+}
+
+void X11CharacterInjectorTest::FillUntilFull(bool immediately_run) {
+  injector_->Inject(1);
+  injector_->Inject(2);
+  injector_->Inject(3);
+  injector_->Inject(4);
+  injector_->Inject(5);
+
+  keyboard_->ExpectChangeKeyMapping(
+      {{55, 1}, {54, 2}, {53, 3}, {52, 4}, {51, 5}});
+
+  keyboard_->ExpectKeyPress(
+      {{base::TimeDelta(), base::TimeDelta::Max(), 55},
+       {base::TimeDelta(), TimeDeltaMs(10), 54},
+       {base::TimeDelta(), TimeDeltaMs(10), 53},
+       {base::TimeDelta(), TimeDeltaMs(10), 52},
+       {base::TimeDelta(), TimeDeltaMs(10), 51}});
+  if (immediately_run) {
+    run_loop_->Run();
+    ResetRunLoop();
+  }
+}
+
+TEST_F(X11CharacterInjectorTest, TestNoMappingNoExpectation) {
+  base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,
+                                                run_loop_->QuitClosure());
+}
+
+TEST_F(X11CharacterInjectorTest, TestTypeOneCharacter) {
+  injector_->Inject(123);
+
+  keyboard_->ExpectChangeKeyMapping({{55, 123}});
+  keyboard_->ExpectKeyPress({{base::TimeDelta(), base::TimeDelta::Max(), 55}});
+}
+
+TEST_F(X11CharacterInjectorTest, TestMapCharactersUntilFull) {
+  FillUntilFull(false);
+}
+
+TEST_F(X11CharacterInjectorTest, TestMapOneCharacterWhenFull) {
+  FillUntilFull(false);
+  injector_->Inject(6);
+
+  keyboard_->ExpectChangeKeyMapping({{55, 6}});
+
+  keyboard_->ExpectKeyPress({{TimeDeltaMs(kMappingExpireMs - 50),
+                              TimeDeltaMs(kMappingExpireMs + 50), 55}});
+}
+
+TEST_F(X11CharacterInjectorTest, TestImmediatelyReuseOldKeycodeAfterExpired) {
+  FillUntilFull(true);
+
+  usleep((kMappingExpireMs + 50) * 1000);
+
+  injector_->Inject(6);
+
+  keyboard_->ExpectChangeKeyMapping({{55, 6}});
+
+  keyboard_->ExpectKeyPress(
+      {{base::TimeDelta(), base::TimeDelta::Max(), 55}});
+}
+
+TEST_F(X11CharacterInjectorTest, TestReusingMappedCharacterLowersPriority) {
+  FillUntilFull(true);
+
+  usleep((kMappingExpireMs + 50) * 1000);
+
+  injector_->Inject(1);
+  injector_->Inject(6);
+
+  keyboard_->ExpectChangeKeyMapping({{54, 6}});
+
+  keyboard_->ExpectKeyPress(
+      {{base::TimeDelta(), base::TimeDelta::Max(), 55},
+       {base::TimeDelta(), TimeDeltaMs(10), 54}});
+}
+
+TEST_F(X11CharacterInjectorTest, TestOrderAfterReusingCharacters) {
+  FillUntilFull(true);
+
+  injector_->Inject(2);
+  injector_->Inject(4);
+  injector_->Inject(5);
+  injector_->Inject(1);
+  injector_->Inject(3);
+
+  keyboard_->ExpectKeyPress(
+        {{base::TimeDelta(), base::TimeDelta::Max(), 54},
+         {base::TimeDelta(), TimeDeltaMs(10), 52},
+         {base::TimeDelta(), TimeDeltaMs(10), 51},
+         {base::TimeDelta(), TimeDeltaMs(10), 55},
+         {base::TimeDelta(), TimeDeltaMs(10), 53}});
+
+  run_loop_->Run();
+  ResetRunLoop();
+
+  usleep((kMappingExpireMs + 50) * 1000);
+
+  injector_->Inject(31);
+  injector_->Inject(32);
+  injector_->Inject(33);
+  injector_->Inject(34);
+  injector_->Inject(35);
+
+  keyboard_->ExpectChangeKeyMapping({
+    {54, 31}, {52, 32}, {51, 33}, {55, 34}, {53, 35}});
+
+  keyboard_->ExpectKeyPress(
+        {{base::TimeDelta(), base::TimeDelta::Max(), 54},
+         {base::TimeDelta(), TimeDeltaMs(10), 52},
+         {base::TimeDelta(), TimeDeltaMs(10), 51},
+         {base::TimeDelta(), TimeDeltaMs(10), 55},
+         {base::TimeDelta(), TimeDeltaMs(10), 53}});
+}
+
+}  // namespace remoting