[Remoting Host] Handle text event characters that are not presented on the keyboard

remoting/host/linux/mock_x11_keyboard.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_HOST_LINUX_MOCK_X11_KEYBOARD_H_
+#define REMOTING_HOST_LINUX_MOCK_X11_KEYBOARD_H_
+
+#include <remoting/host/linux/x11_keyboard.h>
+#include "base/macros.h"
+
+#include "testing/gmock/include/gmock/gmock.h"
+
+namespace remoting {
+
+class MockX11Keyboard : public X11Keyboard {

[Sergey Ulanov, 2016/09/23 18:51:26]

In this case I think the tests would be significantly simpler and easier to read
with fake class instead of a mock.
Here is how it could be implemented:
 - FakeX11Keyboard would implement the same logic that's used in X11 to map
characters (simple keycode to codepoint map). Each character should be mapped
with some small delay to emulate normal behavior of X11 apps. It would then
store the sequence of characters that were injected, with their timestamps.
 - The test would try to inject a sequence of characters and then verify that
correct sequence is injected. The test could also verify that proper delays were
inserted between injected keys.

I think this approach would allow to merge X11CharacterInjector with
X11KeyMapper and test them together. Currently X11CharacterInjector doesn't have
any tests, which is not ideal.
Also the tests would be much simpler. In general GMock-based tests are not very
readable and big PITA to work with (e.g. when refactoring). Here is an old but
still relevant thread about gmock:
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/-KH_IP0rIWQ/dis...

[Sergey Ulanov, 2016/09/23 18:51:26]

Put this class in x11_key_mapper_unittest.cc . It's not likely to be useful
anywhere else.

[Yuwei, 2016/09/26 17:57:19]

Done.

[Yuwei, 2016/09/26 17:57:19]

Done.

+ public:
+  MockX11Keyboard();
+  ~MockX11Keyboard() override;
+
+  MOCK_METHOD0(GetUnusedKeycodes, std::vector<uint32_t>());
+  MOCK_METHOD2(PressKey, void(uint32_t, uint32_t));

[Sergey Ulanov, 2016/09/23 18:51:27]

add parameter names for all parameters

[Yuwei, 2016/09/26 17:57:19]

Obsolete.

+  MOCK_METHOD3(FindKeycode, bool(uint32_t, uint32_t*, uint32_t*));
+  MOCK_METHOD2(ChangeKeyMapping, bool(uint32_t, uint32_t));
+
+  void Flush() override;

[Sergey Ulanov, 2016/09/23 18:51:26]

If this is a Mock class, then it's best to mock all methods. Then add
EXPECT_CALL() if you don't want to verify that they are called properly.

[Yuwei, 2016/09/26 17:57:19]

Obsolete.

+  void Sync() override;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(MockX11Keyboard);
+};
+
+}  // namespace remoting
+#endif  // REMOTING_HOST_LINUX_MOCK_X11_KEYBOARD_H_